[Django] #30478: Do not require npm installed for JavaScript tests (tox -e javascript)
Django
-------------------------------------+-------------------------------------
Reporter: Ivan | Owner: Ivan Kolodyazhny
Kolodyazhny |
Type: | Status: assigned
Uncategorized |
Component: | Version: 2.2
Uncategorized |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
We can omit Node.JS/npm installation for JavaScript tests by using nodeenv
(https://pypi.org/project/nodeenv/)
--
Ticket URL: <https://code.djangoproject.com/ticket/30478>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| Kolodyazhny
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => wontfix
Comment:
I'm not initially seeing the benefit here. `nodeenv` doesn't avoid you
needing to install node/npm. It just does controls that process for you,
allowing you to install and manage multiple node versions.
The PyPI package is just a wrapper around
[https://github.com/ekalinin/nodeenv the main `nodeenv` project] right? I
can see that someone might want to use this themselves. (I use it in
fact.) But I can't see why I'd want to install this in my Python
virtualenv: it strikes me as adding a nesting where we don't need one.
(I'm sure the Zen of Python says something about that. 🙂)
Installing node is not a big issue IMO.
--
Ticket URL: <https://code.djangoproject.com/ticket/30478#comment:1>
Django
-------------------------------------+-------------------------------------
| Kolodyazhny
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Ivan Kolodyazhny):
You're right, Carlton. I'm just trying to keep my development environment
as clean as possible without the installation of some software which is
not required to be installed on my laptop or desktop.
--
Ticket URL: <https://code.djangoproject.com/ticket/30478#comment:2>