[Django] #30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

4 views
Skip to first unread message

Django

unread,
May 29, 2019, 8:58:47 AM5/29/19
to django-...@googlegroups.com
#30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)
-------------------------------------+-------------------------------------
Reporter: Tobias | Owner: nobody
Krönke |
Type: Bug | Status: new
Component: Database | Version: 2.2
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
As wished by Adam (https://github.com/adamchainz/django-
mysql/issues/50#issuecomment-496665473) I will give it a try and do a PR
to turn those tuples into lists. Even the method comments in
https://github.com/django/django/blob/master/django/db/models/sql/compiler.py
all state:

Return the SQL string and **list** of parameters.

--
Ticket URL: <https://code.djangoproject.com/ticket/30529>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 29, 2019, 10:26:09 AM5/29/19
to django-...@googlegroups.com
#30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tobias Krönke):

* status: new => closed
* resolution: => invalid


Comment:

Tuples, it is. https://github.com/django/django/pull/11430

--
Ticket URL: <https://code.djangoproject.com/ticket/30529#comment:1>

Reply all
Reply to author
Forward
0 new messages