[Django] #24703: Use MigrationLoader in squashmigrations
Django
--------------------------------------+--------------------
Reporter: knbk | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+--------------------
Just a small thing I noticed: squashmigrations creates a
`MigrationExecutor`, but only ever uses the `executor.loader` attribute.
It would be cleaner to directly use a `MigrationLoader`, same as in
`makemigrations` and `showmigrations`.
--
Ticket URL: <https://code.djangoproject.com/ticket/24703>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: knbk | Owner: knbk
Type: | Status: assigned
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by knbk):
* owner: nobody => knbk
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
Comment:
PR: https://github.com/django/django/pull/4561
--
Ticket URL: <https://code.djangoproject.com/ticket/24703#comment:1>
Django
Reporter: knbk | Owner: knbk
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by MarkusH):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24703#comment:2>
Django
Reporter: knbk | Owner: knbk
Type: | Status: assigned
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by MarkusH):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24703#comment:3>
Django
Reporter: knbk | Owner: knbk
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Markus Holtermann <info@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1521861b3cc07fffdbe95c41000bf8e8ef92cc6b" 1521861]:
{{{
#!CommitTicketReference repository=""
revision="1521861b3cc07fffdbe95c41000bf8e8ef92cc6b"
Fixed #24703 -- Changed squashmigrations to use a MigrationLoader
Changed squashmigrations to not instantiate a MigrationExecutor,
but to directly use a MigrationLoader instance instead.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24703#comment:4>