[Django] #22770: Remove create_superuser from post_migrate signals
Django
------------------------------------------------+------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
In IRC, Loic and I were in agreement that the prompt to create a superuser
every time after you run `migrate` can be annoying. Running
`createsuperuser` manually is not much of a burden if you do need it. I
think we could make the change without a deprecation as it's not clear to
me that doing so would offer any benefits.
--
Ticket URL: <https://code.djangoproject.com/ticket/22770>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
[https://github.com/django/django/pull/2788 PR] (proposing to include it
in 1.7).
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:1>
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by manfre):
If this type of change was proposed by a non core dev, would it even be
considered given that 1.7 is already late in the beta stage?
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:2>
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timo):
I added the logic back to `syncdb` for backwards compatibility. Making the
change now means we don't have to worry about people expecting the
behavior with `migrate`.
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:3>
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"93d05536fd8179483c725467de8e33454b48a430"]:
{{{
#!CommitTicketReference repository=""
revision="93d05536fd8179483c725467de8e33454b48a430"
Fixed #22770 -- Removed create_superuser from post_migrate signals.
Moved logic to syncdb command for backwards compatibility.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:4>
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"0767055dfc255ba120811f6d9cba2c7e593b0731"]:
{{{
#!CommitTicketReference repository=""
revision="0767055dfc255ba120811f6d9cba2c7e593b0731"
[1.7.x] Fixed #22770 -- Removed create_superuser from post_migrate
signals.
Moved logic to syncdb command for backwards compatibility.
Backport of 93d05536fd from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:5>
Django
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by yoyoma):
I created https://github.com/django/django/pull/3143 to address the single
remaining documentation straggler.
--
Ticket URL: <https://code.djangoproject.com/ticket/22770#comment:6>