[Django] #29211: update_or_create with column named defaults

2 views
Skip to first unread message

Django

unread,
Mar 12, 2018, 6:53:44 AM3/12/18
to django-...@googlegroups.com
#29211: update_or_create with column named defaults
-------------------------------------+-------------------------------------
Reporter: James Pic | Owner: nobody
Type: New | Status: new
feature |
Component: Database | Version: 2.0
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, signature is: update_or_create(defaults=None, **kwargs)

This means that it's not possible to with a column named "defaults".

Perhaps it would be better to accept a dict in args, since we reserve
kwargs for column names ?

--
Ticket URL: <https://code.djangoproject.com/ticket/29211>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 12, 2018, 7:45:02 AM3/12/18
to django-...@googlegroups.com
#29211: update_or_create with column named defaults
-------------------------------------+-------------------------------------
Reporter: James Pic | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jani Tiainen):

* status: new => closed
* resolution: => wontfix


Comment:

{{{update_or_create()}}} uses same parameters as {{{get_or_create()}}},
and from the {{{get_or_create()}}} docs:

> If you have a field named defaults and want to use it as an exact lookup
in {{{get_or_create()}}}, just use {{{'defaults__exact'}}}, like so:
> {{{#!python
> Foo.objects.get_or_create(defaults__exact='bar', defaults={'defaults':
'baz'})
> }}}

Closing as won't fix.

--
Ticket URL: <https://code.djangoproject.com/ticket/29211#comment:1>

Reply all
Reply to author
Forward
0 new messages