[Django] #22744: inspectdb test failure on spatialite

8 views
Skip to first unread message

Django

unread,
May 31, 2014, 2:37:08 PM5/31/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
-------------------------------------------+----------------------------
Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.7-beta-2
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+----------------------------
New in 1.7:
{{{
======================================================================
ERROR [0.001s]: test_special_column_name_introspection
(inspectdb.tests.InspectDBTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/tests/inspectdb/tests.py",
line 177, in test_special_column_name_introspection
call_command('inspectdb', stdout=out)
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/core/management/__init__.py",
line 112, in call_command
return klass.execute(*args, **defaults)
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/core/management/base.py",
line 337, in execute
output = self.handle(*args, **options)
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/core/management/base.py",
line 532, in handle
return self.handle_noargs(**options)
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/core/management/commands/inspectdb.py",
line 27, in handle_noargs
for line in self.handle_inspection(options):
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/core/management/commands/inspectdb.py",
line 63, in handle_inspection
relations = connection.introspection.get_relations(cursor, table_name)
File "/var/lib/jenkins/workspace/django-
spatialite/database/spatialite/python/python2.7/django/db/backends/sqlite3/introspection.py",
line 82, in get_relations
results = cursor.fetchone()[0].strip()
TypeError: 'NoneType' object has no attribute '__getitem__'
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22744>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 31, 2014, 4:29:35 PM5/31/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
---------------------------------+--------------------------------------

Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.7-beta-2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by aaugustin):

I never managed to compile spatialite and I assume I'm not the only one
:-/

If you had the time to bisect the failure, someone would then feel
responsible for fixing it ;-)

--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:1>

Django

unread,
May 31, 2014, 6:16:29 PM5/31/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
---------------------------------+--------------------------------------

Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.7-beta-2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by timo):

* cc: claudep (added)


Comment:

bisected to 2af58a2cef8b0d30c18f6d0d106cb0e093c673ab

--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:2>

Django

unread,
May 31, 2014, 6:38:19 PM5/31/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
---------------------------------+--------------------------------------
Reporter: timo | Owner: claudep
Type: Bug | Status: assigned
Component: GIS | Version: 1.7-beta-2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by claudep):

* status: new => assigned
* owner: nobody => claudep


--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:3>

Django

unread,
Jun 1, 2014, 2:35:48 PM6/1/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
-------------------------------------+-------------------------------------

Reporter: timo | Owner: claudep
Type: Bug | Status: assigned
Component: GIS | Version:
Severity: Release blocker | 1.7-beta-2
Keywords: | Resolution:
Has patch: 0 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by charettes):

* stage: Accepted => Ready for checkin


Comment:

Patch looks good to me, test pass with and without `pysqlite` on Py27.

--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:4>

Django

unread,
Jun 1, 2014, 4:07:23 PM6/1/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
-------------------------------------+-------------------------------------
Reporter: timo | Owner: claudep
Type: Bug | Status: closed

Component: GIS | Version:
Severity: Release blocker | 1.7-beta-2
Keywords: | Resolution: fixed

Has patch: 0 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5a504a5311b0108586e633128f6ef8be6e05249a"]:
{{{
#!CommitTicketReference repository=""
revision="5a504a5311b0108586e633128f6ef8be6e05249a"
Fixed #22744 -- Fixed sqlite3 get_relations introspection with views

Thanks Tim Graham for the report and Simon Charette for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:5>

Django

unread,
Jun 1, 2014, 4:08:07 PM6/1/14
to django-...@googlegroups.com
#22744: inspectdb test failure on spatialite
-------------------------------------+-------------------------------------
Reporter: timo | Owner: claudep
Type: Bug | Status: closed
Component: GIS | Version:
Severity: Release blocker | 1.7-beta-2
Keywords: | Resolution: fixed
Has patch: 0 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"a2fb5c9d69b0a7bfbb7f5576eb9e801c159a1f0b"]:
{{{
#!CommitTicketReference repository=""
revision="a2fb5c9d69b0a7bfbb7f5576eb9e801c159a1f0b"
[1.7.x] Fixed #22744 -- Fixed sqlite3 get_relations introspection with
views

Thanks Tim Graham for the report and Simon Charette for the review.

Backport of 5a504a5311 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22744#comment:6>

Reply all
Reply to author
Forward
0 new messages