[Django] #36914: Inconsistent option background color in M2M select widget for TabularInline.

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+-----------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component: contrib.admin
Version: 6.0 | Severity: Normal
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+-----------------------------------------
In #35809, the select widget option background color was changed (to
improve color contrast).

[[Image(background_color_example.png)]]

It seems that the changed color is not being applied to fields within
`TabularInline`.
--
Ticket URL: <https://code.djangoproject.com/ticket/36914>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------

Reporter: Antoliny | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: 6.0

Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Changes (by Antoliny):

* Attachment "background_color_example.png" added.

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned

Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:1>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/20665 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:2>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Changes (by jaffar Khan):

* Attachment "Background.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/36914>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by jaffar Khan):

* has_patch: 1 => 0

Comment:

In reproducing this bug I noticed that tabularInline background color
contrast of selected rows is very poor, the text can't be read when we
select rows:
[[Image(Background.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:3>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by jaffar Khan):

* cc: jaffar Khan (added)

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:4>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Comment (by Jacob Walls):

Thanks for the report -- do you have a test model or a unit test, or a
reproducer I can check out?
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:5>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Comment (by Antoliny):

Replying to [comment:3 jaffar Khan]:

> In reproducing this bug I noticed that tabularInline background color
contrast of selected rows is very poor, the text can't be read when we
select rows:
> [[Image(Background.png)]]

Yes, that's right. It's an issue caused by the default font color in Edge
browser.
A related ticket(#36513) already exists!
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:6>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Changes (by Jacob Walls):

* needs_tests: 0 => 1

Comment:

I couldn't find evidence of a TabularInline with a ManyToManyField in the
admin_views screenshots tests, but maybe Antoliny knows of one?
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:7>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Changes (by Jacob Walls):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:8>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Changes (by Antoliny):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:9>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Antoliny):

> I couldn't find evidence of a TabularInline with a ManyToManyField in
the admin_views screenshots tests, but maybe Antoliny knows of one?

Yes, I think it needs testing.
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:10>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

Comment:

A merge conflict to address.
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:11>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:12>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.

-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:13>

[Django]

#36914: Inconsistent option background color in M2M select widget for
TabularInline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"21664867b60a49c25cf93191a81f335a5eafca53" 2166486]:
{{{#!CommitTicketReference repository=""
revision="21664867b60a49c25cf93191a81f335a5eafca53"
Fixed #36914 -- Fixed background-color to also apply to select options in
TabularInline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36914#comment:14>