Re: [Django] #35961: Support PEP639-style license indicator in pyproject.toml

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Jacob
| Walls
Type: Bug | Status: assigned
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: packaging, license | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* keywords: packaging => packaging, license
* owner: Ahmed Nassar => Jacob Walls
* severity: Normal => Release blocker
* type: Cleanup/optimization => Bug
* version: dev => 4.2


Old description:

> See https://peps.python.org/pep-0639/ and
>
> https://github.com/django/django/commit/c278fec52a3114e7488e1f10a0070d13ea8b084d

New description:

See https://peps.python.org/pep-0639/

--
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------

Reporter: Michiel Beijen | Owner: Michiel
| Beijen

Type: Bug | Status: assigned
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution:

Keywords: packaging, license | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 1 => 0
* owner: Jacob Walls => Michiel Beijen
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:12>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen

Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"96a7a652166bece8acc96d6335ebb8091de2f496" 96a7a65]:
{{{#!CommitTicketReference repository=""
revision="96a7a652166bece8acc96d6335ebb8091de2f496"
Fixed #35961 -- Migrated license metadata in pyproject.toml to conform PEP
639.

See https://peps.python.org/pep-0639/ and
https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-and-license-files.

Co-authored-by: Jacob Walls <jacobty...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:13>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"d0d2dd7706ab8c852a113547c6b9973baf3c7e16" d0d2dd77]:
{{{#!CommitTicketReference repository=""
revision="d0d2dd7706ab8c852a113547c6b9973baf3c7e16"
[6.0.x] Fixed #35961 -- Migrated license metadata in pyproject.toml to

conform PEP 639.

See https://peps.python.org/pep-0639/ and
https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-and-license-files.

Co-authored-by: Jacob Walls <jacobty...@gmail.com>

Backport of 96a7a652166bece8acc96d6335ebb8091de2f496 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:14>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"c05c5b80a6108f84f786da46ba5de3a4972b9b73" c05c5b80]:
{{{#!CommitTicketReference repository=""
revision="c05c5b80a6108f84f786da46ba5de3a4972b9b73"
[5.2.x] Fixed #35961 -- Migrated license metadata in pyproject.toml to

conform PEP 639.

See https://peps.python.org/pep-0639/ and
https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-and-license-files.

Co-authored-by: Jacob Walls <jacobty...@gmail.com>

Backport of 96a7a652166bece8acc96d6335ebb8091de2f496 from main.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:15>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"7da2bf97d69e7f2af5da55cbc952b5a7ba9fdcf4" 7da2bf9]:
{{{#!CommitTicketReference repository=""
revision="7da2bf97d69e7f2af5da55cbc952b5a7ba9fdcf4"
[5.1.x] Fixed #35961 -- Migrated license metadata in pyproject.toml to

conform PEP 639.

See https://peps.python.org/pep-0639/ and
https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-and-license-files.

Co-authored-by: Jacob Walls <jacobty...@gmail.com>

Backport of 96a7a652166bece8acc96d6335ebb8091de2f496 from main.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:16>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

Not migrating to 4.2.x until strictly necessary as Jacob mentioned in the
PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:17>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by stefan6419846):

This change seems to have removed the `AUTHORS` file from `*.dist-
info/licenses` due to explicitly declaring the list of license files to
use. Is this intended or an unexpected side effect?
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:18>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls):

Thanks -- I was not aware that the `AUTHORS` file was previously included
in `*.dist-info/licenses`. I see the packaging user guide
[https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-files example] includes such a file, so I would accept a PR
adding it to `license-files`. Would you like to do that? You can prefix it
`Refs #35961 -- ...`.
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:19>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Michiel Beijen):

Hi stefan, thanks for spotting this! I was the one that created the
original PR which caused this, I'm sorry.
My new PR for adding back the AUTHORS file explicitly is here -->
https://github.com/django/django/pull/20638
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:20>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"220db1c78a1bdeb3ccb91ba8bf0b7ab829379c35" 220db1c]:
{{{#!CommitTicketReference repository=""
revision="220db1c78a1bdeb3ccb91ba8bf0b7ab829379c35"
Refs #35961 -- Restored AUTHORS in wheel.

As a side effect from adding explicit license files to conform to PEP 639,
the
AUTHORS file got dropped from the wheel. The tarball still contained this
file.

In the "Python Packaging User Guide"
(https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-files)
the AUTHORS file is modeled to be included in license-files.

Follow-up to 96a7a652166bece8acc96d6335ebb8091de2f496.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:21>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"dab569a1e8bd1a7673246ef5741f62c9d157c005" dab569a1]:
{{{#!CommitTicketReference repository=""
revision="dab569a1e8bd1a7673246ef5741f62c9d157c005"
[6.0.x] Refs #35961 -- Restored AUTHORS in wheel.

As a side effect from adding explicit license files to conform to PEP 639,
the
AUTHORS file got dropped from the wheel. The tarball still contained this
file.

In the "Python Packaging User Guide"
(https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-files)
the AUTHORS file is modeled to be included in license-files.

Follow-up to 96a7a652166bece8acc96d6335ebb8091de2f496.

Backport of 220db1c78a1bdeb3ccb91ba8bf0b7ab829379c35 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:22>

[Django]

#35961: Support PEP639-style license indicator in pyproject.toml
-------------------------------------+-------------------------------------
Reporter: Michiel Beijen | Owner: Michiel
| Beijen
Type: Bug | Status: closed
Component: Packaging | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: packaging, license | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"420c7071f35c7ba9ce2bf936b4d870c0be6a142c" 420c707]:
{{{#!CommitTicketReference repository=""
revision="420c7071f35c7ba9ce2bf936b4d870c0be6a142c"
[5.2.x] Refs #35961 -- Restored AUTHORS in wheel.

As a side effect from adding explicit license files to conform to PEP 639,
the
AUTHORS file got dropped from the wheel. The tarball still contained this
file.

In the "Python Packaging User Guide"
(https://packaging.python.org/en/latest/guides/writing-pyproject-toml
/#license-files)
the AUTHORS file is modeled to be included in license-files.

Follow-up to 96a7a652166bece8acc96d6335ebb8091de2f496.
Backport of 220db1c78a1bdeb3ccb91ba8bf0b7ab829379c35 from main.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/35961#comment:23>