Re: [Django] #36806: Add system check for null kwarg in GeneratedField definition

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* keywords: => GeneratedField
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------

Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned

Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Nilesh Pahari):

* owner: (none) => Nilesh Pahari
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:5>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nilesh Pahari):

* needs_docs: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:6>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1

Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nilesh Pahari):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:7>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Nilesh Pahari):

PR: https://github.com/django/django/pull/20421
--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:8>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_docs: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:9>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned

Component: Database layer | Version: dev

(models, ORM) |
Severity: Normal | Resolution:

Keywords: GeneratedField | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin
* version: 5.2 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:10>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: GeneratedField | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Dai-Tado):

Thank you!!
--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:11>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari

Cleanup/optimization | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: GeneratedField | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"6025eab3c509b4de922117e16866bbfe0ee99aa6" 6025eab]:
{{{#!CommitTicketReference repository=""
revision="6025eab3c509b4de922117e16866bbfe0ee99aa6"
Fixed #36806 -- Added system check for null kwarg in GeneratedField.

The null argument has no effect on GeneratedField since the nullability
of the column depends on the database and expression used.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:12>

[Django]

#36806: Add system check for null kwarg in GeneratedField definition
-------------------------------------+-------------------------------------
Reporter: Dai-Tado | Owner: Nilesh
Type: | Pahari
Cleanup/optimization | Status: closed
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: GeneratedField | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"968f3f96373e028f1486d135e38331fcd0e3a0ca" 968f3f96]:
{{{#!CommitTicketReference repository=""
revision="968f3f96373e028f1486d135e38331fcd0e3a0ca"
Refs #36806 -- Removed unnecessary null=True from GeneratedField in test
models.

Test coverage is preserved because the tests only verify that generated
fields can produce NULL values when the source field is nullable.

This addresses system check warnings in the test suite after
6025eab3c509b4de922117e16866bbfe0ee99aa6.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36806#comment:13>