[Django] #34624: RelatedFieldWidgetWrapper links toggling isn’t working for radio widgets
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: Coen van der Kamp
Colas |
Type: Bug | Status: assigned
Component: | Version: 4.2
contrib.admin |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
In the Redirects contrib module, when creating a new redirect, the first
field is for a Site instance. This is using a radio button (`radio_fields`
ModelAdmin definition:
https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10).
This uses `RelatedFieldWidgetWrapper` – which doesn’t work for radio
widgets.
If we look at
[https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js#L223-L230
RelatedObjectLookups.js], it seems clear this code was only written to
support `select` widgets.
Tagging this `contrib.admin` because it seems to affect all usage of
`RelatedFieldWidgetWrapper` – but as far as I can see in Django itself
only `contrib.redirects` uses radio_fields.
---
In this instance I believe a `select` widget would be a much nicer
experience anyway, so not entirely sure whether it makes sense to change
the widget to fix this, or update the code to support radio buttons, or do
both.
--
Ticket URL: <https://code.djangoproject.com/ticket/34624>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* Attachment "related-links.gif" added.
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Old description:
> In the Redirects contrib module, when creating a new redirect, the first
> field is for a Site instance. This is using a radio button
> (`radio_fields` ModelAdmin definition:
> https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10).
> This uses `RelatedFieldWidgetWrapper` – which doesn’t work for radio
> widgets.
>
> If we look at
> [https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js#L223-L230
> RelatedObjectLookups.js], it seems clear this code was only written to
> support `select` widgets.
>
> Tagging this `contrib.admin` because it seems to affect all usage of
> `RelatedFieldWidgetWrapper` – but as far as I can see in Django itself
> only `contrib.redirects` uses radio_fields.
>
> ---
>
> In this instance I believe a `select` widget would be a much nicer
> experience anyway, so not entirely sure whether it makes sense to change
> the widget to fix this, or update the code to support radio buttons, or
> do both.
New description:
In the Redirects contrib module, when creating a new redirect, the first
field is for a Site instance. This is using a radio button (`radio_fields`
ModelAdmin definition:
https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10).
This uses `RelatedFieldWidgetWrapper` – which doesn’t work for radio
widgets. Demo:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/34624
/related-links.gif)]]
If we look at
[https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js#L223-L230
RelatedObjectLookups.js], it seems clear this code was only written to
support `select` widgets.
Tagging this `contrib.admin` because it seems to affect all usage of
`RelatedFieldWidgetWrapper` – but as far as I can see in Django itself
only `contrib.redirects` uses radio_fields.
---
In this instance I believe a `select` widget would be a much nicer
experience anyway, so not entirely sure whether it makes sense to change
the widget to fix this, or update the code to support radio buttons, or do
both.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Description changed by Thibaud Colas:
Old description:
> In the Redirects contrib module, when creating a new redirect, the first
> field is for a Site instance. This is using a radio button
> (`radio_fields` ModelAdmin definition:
> https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10).
> This uses `RelatedFieldWidgetWrapper` – which doesn’t work for radio
> widgets. Demo:
>
> [[Image(https://code.djangoproject.com/raw-attachment/ticket/34624
> /related-links.gif)]]
>
> If we look at
> [https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js#L223-L230
> RelatedObjectLookups.js], it seems clear this code was only written to
> support `select` widgets.
>
> Tagging this `contrib.admin` because it seems to affect all usage of
> `RelatedFieldWidgetWrapper` – but as far as I can see in Django itself
> only `contrib.redirects` uses radio_fields.
>
> ---
>
> In this instance I believe a `select` widget would be a much nicer
> experience anyway, so not entirely sure whether it makes sense to change
> the widget to fix this, or update the code to support radio buttons, or
> do both.
New description:
Spotted as part of #34622. In the Redirects contrib module, when creating
a new redirect, the first field is for a Site instance. This is using a
radio button (`radio_fields` ModelAdmin definition:
https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10).
This uses `RelatedFieldWidgetWrapper` – which doesn’t work for radio
widgets. Demo:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/34624
/related-links.gif)]]
If we look at
[https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js#L223-L230
RelatedObjectLookups.js], it seems clear this code was only written to
support `select` widgets.
Tagging this `contrib.admin` because it seems to affect all usage of
`RelatedFieldWidgetWrapper` – but as far as I can see in Django itself
only `contrib.redirects` uses radio_fields.
---
In this instance I believe a `select` widget would be a much nicer
experience anyway, so not entirely sure whether it makes sense to change
the widget to fix this, or update the code to support radio buttons, or do
both.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
Accepting since I could easily reproduce the issue. In my opinion, we
could perhaps do two things:
1- Separately consider whether the `redirects` app should be changed to
use a select instead of a radioselect (think of a project with lots of
Django Sites, the radio buttons would consume a lot of screen) This would
be a separated ticket for the `redirects` site.
2- Actually fix the admin's RelatedFieldWidgetWrapper to work with
radioselect or clealry document that only selects are supported.
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Coen van der Kamp):
I'll will first attempt 2.a: "Actually fix the admin's
RelatedFieldWidgetWrapper to work with radioselect".
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/17158
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Coen van
| der Kamp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:6>
Django
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Keywords: | Triage Stage: Accepted
Changes (by Natalia Bidart):
* has_patch: 1 => 0
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* owner: Coen van der Kamp => (none)
* status: assigned => new
* version: 4.2 => dev
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:7>
Django
-------------------------------+------------------------------------
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Hello! What is the status of this ticket?
I am planning to apply for GSoC, and so I think that trying to solve a
ticket would give me a chance to get my hands dirty with the codebase. If
this is not assigned to anyone, can I take a look?
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:8>
Django
-------------------------------+------------------------------------
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Replying to [comment:8 Anirudh Prabhakaran]:
>
> I am planning to apply for GSoC, and so I think that trying to solve a
ticket would give me a chance to get my hands dirty with the codebase. If
this is not assigned to anyone, can I take a look?
existing PR as a starting point. Thanks for wanting to contribute to
Django!
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:9>
Django
-------------------------------+------------------------------------
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
This ticket looks unassigned and it seems no one is currently working on
it. I'd like to try to tackle it and put up a PR if there are no
objections.
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:10>
Django
-------------------------------+------------------------------------
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Replying to [comment:10 Sasa Cocic-Banjanac]:
it. I'd like to try to tackle it and put up a PR if there are no
objections.
if not, I'd like to try have a go on it :)
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:11>
Django
-------------------------------+------------------------------------
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* owner: (none) => devday
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:12>
Django
-------------------------------+------------------------------------
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* owner: devday => 사재혁
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:13>
Django
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Comment (by JaeHyuckSa):
I will submit a PR by the end of today.
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:14>
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
* has_patch: 0 => 1
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:15>
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
-------------------------------+--------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:16>
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
-------------------------------+--------------------------------------
* needs_better_patch: 1 => 0
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:17>
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
-------------------------------+--------------------------------------
* needs_better_patch: 0 => 1
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:18>
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
-------------------------------+--------------------------------------
* needs_better_patch: 1 => 0
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:19>
Django
| JaeHyuckSa
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Sarah Boyce):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:20>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner:
| JaeHyuckSa
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* resolution: => fixed
* status: assigned => closed
Comment:
In [changeset:"0be1c4575b03b9f7ac91ec9aabe0bedb542d20bc" 0be1c457]:
{{{#!CommitTicketReference repository=""
revision="0be1c4575b03b9f7ac91ec9aabe0bedb542d20bc"
Fixed #34624 -- Removed change, delete, and view buttons for non-Select
widgets in RelatedFieldWidgetWrapper.
Signed-off-by: SaJH <wogur...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:21>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner:
| JaeHyuckSa
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
In [changeset:"eaaf01c96a44354c5b0a0450ee49c3031848b489" eaaf01c]:
{{{#!CommitTicketReference repository=""
revision="eaaf01c96a44354c5b0a0450ee49c3031848b489"
Refs #34624 -- Changed RedirectAdmin to use a Select widget for the site
field.
Signed-off-by: SaJH <wogur...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34624#comment:22>