[Django] #36558: Unexpected updated design of the "Show all" link in the admin changelist pagination.

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
----------------------------+-----------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component: contrib.admin
Version: dev | Severity: Normal
Keywords: pagination | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------+-----------------------------------------
Originally, the "Show all" link had the following design on hover.

[[Image(original_show_all.png)]]

It has now been changed as follows.

[[Image(changed_show_all.png)]]

https://github.com/django/django/commit/3f59711581bd22ebd0f13fb040b15b69c0eee21f

This occurred during the pagination accessibility improvement work, and
the design change seems to be unintended.
--
Ticket URL: <https://code.djangoproject.com/ticket/36558>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.

-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: dev

Severity: Normal | Resolution:

Keywords: pagination | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "changed_show_all.png" added.

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: pagination | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "original_show_all.png" added.

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
-------------------------------+--------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: pagination | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:1>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.

---------------------------------+------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev

Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

---------------------------------+------------------------------------
Changes (by Natalia Bidart):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

Comment:

Thank you Antoliny for this report. I can confirm that I see the same
thing, though I also see the "Show all" (and all entry/rows) with an
underline. Personally, the underline bothers me, but is this was already
discussed with the accessibility team, I won't get into that at all.

I can reproduce the "blue hover" for "show all", I don't think it's
terrible but I agree we should ensure it looks like the existing links
where the hover is a darker tone of the text color. I'll attach some
screenshots.
--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:2>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20250818-094905.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/36558>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20250818-094929.png" added.

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------

Comment (by Antoliny):

Replying to [comment:2 Natalia Bidart]:

> Thank you Antoliny for this report. I can confirm that I see the same
thing, though I also see the "Show all" (and all entry/rows) with an
underline. Personally, the underline bothers me, but is this was already
discussed with the accessibility team, I won't get into that at all.
>
> I can reproduce the "blue hover" for "show all", I don't think it's
terrible but I agree we should ensure it looks like the existing links
where the hover is a darker tone of the text color. I'll attach some
screenshots.

Thanks for adding the screenshots.
I think in my example the branch wasn’t up to date, which is why the
underline didn’t appear.

The underline was added in this
[https://code.djangoproject.com/ticket/34917 ticket] and was intentionally
included for accessibility reasons.

I also agree that it would be better if the hover state matched the
existing links by showing a darker tone of the text color.
Currently, the pagination button design is being applied to "show all."
--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:3>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------

Changes (by Antoliny):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/19747 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:4>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------

Changes (by Sarah Boyce):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:5>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: pagination | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------

Changes (by Antoliny):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:6>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.

-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:

Keywords: pagination | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:7>

[Django]

#36558: Unexpected updated design of the "Show all" link in the admin changelist
pagination.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed

Keywords: pagination | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"0b2493a0da14ea91027fec7c95cb63af126e3296" 0b2493a]:
{{{#!CommitTicketReference repository=""
revision="0b2493a0da14ea91027fec7c95cb63af126e3296"
Fixed #36558, Refs #36366 -- Fixed the "show all" link hover styling in
admin pagination.

Regression in 3f59711581bd22ebd0f13fb040b15b69c0eee21f.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36558#comment:8>