[Django] #35892: Support Widget.use_fieldset in admin forms

27 views
Skip to first unread message

Django

unread,
Nov 6, 2024, 11:01:36 AM11/6/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Type:
| Cleanup/optimization
Status: new | Component:
| contrib.admin
Version: 5.0 | Severity: Normal
Keywords: accessibility | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Currently, the admin doesn't respect
[https://docs.djangoproject.com/en/5.1/ref/forms/widgets/#django.forms.Widget.use_fieldset
Widget.use_fieldset]

When a widget has this set, the field should be rendered in a fieldset,
ideally with a legend tag (or the fieldset using `aria-labelledby`) and
have `aria-describedby` to associate the helptext to the fieldset

All admin widgets should be reviewed as to whether `use_fieldset` should
be `True`

See this PR discussion for context:
https://github.com/django/django/pull/18742#issuecomment-2460108968
--
Ticket URL: <https://code.djangoproject.com/ticket/35892>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 6, 2024, 1:03:56 PM11/6/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tom Carrick):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:1>

Django

unread,
Nov 9, 2024, 4:15:40 AM11/9/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: SAI
Type: | GANESH S
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by SAI GANESH S):

* cc: SAI GANESH S (added)
* owner: (none) => SAI GANESH S
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:2>

Django

unread,
Nov 13, 2024, 2:48:11 AM11/13/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: SAI
Type: | GANESH S
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by SAI GANESH S):

* has_patch: 0 => 1

Comment:

https://github.com/django/django/pull/18803
--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:3>

Django

unread,
Nov 13, 2024, 3:30:35 AM11/13/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: SAI
Type: | GANESH S
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:4>

Django

unread,
Nov 24, 2024, 3:48:05 AM11/24/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by SAI GANESH S):

* cc: SAI GANESH S (removed)
* owner: SAI GANESH S => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:5>

Django

unread,
Dec 4, 2024, 4:35:27 AM12/4/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* cc: Antoliny (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:6>

Django

unread,
Dec 4, 2024, 8:46:17 AM12/4/24
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner:
Type: | JakeWalson
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JakeWalson):

* owner: (none) => JakeWalson
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:7>

Django

unread,
Jan 30, 2025, 3:12:55 AMJan 30
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner:
Type: | JakeWalson
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Antoliny):

Replying to [comment:7 JakeWalson]:
are you still working on this ticket? if your not can i work this ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:8>

Django

unread,
Jan 30, 2025, 6:10:56 AMJan 30
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner:
Type: | JakeWalson
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by JakeWalson):

Replying to [comment:8 Antoliny]:
> Replying to [comment:7 JakeWalson]:
> are you still working on this ticket? if your not can i work this
ticket?
I'm currently working on this ticket. Let me know if you need any updates
or if there's anything specific you'd like to discuss!
--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:9>

Django

unread,
Jul 26, 2025, 1:32:47 AMJul 26
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* owner: JakeWalson => Antoliny

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:10>

Django

unread,
Jul 27, 2025, 7:06:26 PMJul 27
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Antoliny):

[https://github.com/django/django/pull/19678 NEW PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:11>

Django

unread,
Jul 27, 2025, 7:10:45 PMJul 27
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:12>

Django

unread,
Jul 29, 2025, 3:41:57 AMJul 29
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:13>

Django

unread,
Jul 30, 2025, 7:17:12 AMJul 30
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:14>

Django

unread,
Aug 4, 2025, 8:52:22 AMAug 4
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:15>

Django

unread,
Aug 4, 2025, 11:30:38 PMAug 4
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:16>

Django

unread,
Aug 12, 2025, 8:02:39 AMAug 12
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:17>

Django

unread,
Aug 12, 2025, 7:13:31 PMAug 12
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:18>

Django

unread,
Aug 13, 2025, 4:21:59 AMAug 13
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:19>

Django

unread,
Aug 19, 2025, 10:36:08 AMAug 19
to django-...@googlegroups.com
#35892: Support Widget.use_fieldset in admin forms
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Antoliny
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"4187da258fe212d494cb578a0bc2b52c4979ab95" 4187da2]:
{{{#!CommitTicketReference repository=""
revision="4187da258fe212d494cb578a0bc2b52c4979ab95"
Fixed #35892 -- Supported Widget.use_fieldset in admin forms.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35892#comment:20>
Reply all
Reply to author
Forward
0 new messages