[Django] #36528: When "view_on_site" is set to True, the rendered button has an underline.

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
----------------------------+-----------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component: contrib.admin
Version: 5.2 | Severity: Normal
Keywords: changeform | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
----------------------------+-----------------------------------------
In this
[https://github.com/django/django/commit/849f8307a5bb33465252d0891a9b2c47dde65889
commit]([https://code.djangoproject.com/ticket/34917 ticket]), we added
underlines to links to improve accessibility.
However, the "view on site" button in the changeform should not have an
underline, but it currently does.
It seems this part was missed in the above commit.

[[Image(Screenshot 2025-07-28 at 8.20.41 AM.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/36528>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.

-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: 5.2

Severity: Normal | Resolution:

Keywords: changeform | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "Screenshot 2025-07-28 at 8.20.41 AM.png" added.

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.

-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: changeform | Triage Stage: Accepted
viewonsite |

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* keywords: changeform => changeform viewonsite
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
* version: 5.2 => dev

Comment:

Thank you Antoliny! I can confirm I get the same underline as reported.
Setting this ticket as release blocker for 6.0.
--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:1>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: changeform | Triage Stage: Accepted
viewonsite |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:2>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: changeform | Triage Stage: Accepted
viewonsite |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/19682 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:3>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: changeform | Triage Stage: Accepted
viewonsite |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:4>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: changeform | Triage Stage: Accepted
viewonsite |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:5>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:

Keywords: changeform | Triage Stage: Ready for
viewonsite | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:6>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed

Keywords: changeform | Triage Stage: Ready for
viewonsite | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"792ca148a2d6da6cf0778f6a866c899208ab94f9" 792ca148]:
{{{#!CommitTicketReference repository=""
revision="792ca148a2d6da6cf0778f6a866c899208ab94f9"
Fixed #36528, Refs #34917 -- Removed role="button" from object-tools
links.

Regression in 849f8307a5bb33465252d0891a9b2c47dde65889.
In order to prevent underlines on links styled like buttons, role="button"
was added.
This has been removed and the style updated to reflect that these are
links.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:7>

[Django]

#36528: When "view_on_site" is set to True, the rendered button has an underline.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: changeform | Triage Stage: Ready for
viewonsite | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"3bd583f55b79f4dae9c5855e58f2e7749c75fb13" 3bd583f]:
{{{#!CommitTicketReference repository=""
revision="3bd583f55b79f4dae9c5855e58f2e7749c75fb13"
Refs #36528 -- Fixed link underline typo in CSS.

Regression in 792ca148a2d6da6cf0778f6a866c899208ab94f9.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36528#comment:8>