[Django] #36512: The range of the pagination block on the admin ChangeList page is incorrect.

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component:
| contrib.admin
Version: 5.2 | Severity: Normal
Keywords: changelist, | Triage Stage:
pagination | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Recently, accessibility improvements were made to the `ChangeList`
pagination on the admin page.[https://github.com/django/django/pull/19448
PR]
As part of that process, the save button that was previously within the
pagination block was separated.
However, the current pagination block still includes the save button
within its range.
{{{
{% block pagination %}
<div class="changelist-footer">
{% pagination cl %}
{% if cl.formset and cl.result_count %}<input type="submit"
name="_save" class="default" value="{% translate 'Save' %}">{% endif %}
{% endblock %}
</div>
}}}
As a result, when overriding the template and customizing the contents of
the pagination block, the save button may be unintentionally removed.
The range of the pagination block should be adjusted to include only the
pagination template tags.
--
Ticket URL: <https://code.djangoproject.com/ticket/36512>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------

Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:

Keywords: changelist, | Triage Stage:
pagination | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36512#comment:1>

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: changelist, | Triage Stage:
pagination | Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36512#comment:2>

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: changelist, | Triage Stage:
pagination | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Antoliny):

[https://github.com/django/django/pull/19657 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36512#comment:3>

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution: invalid

Keywords: changelist, | Triage Stage:
pagination | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* resolution: => invalid
* status: assigned => closed

Comment:

Previously the save button was included in
`django/contrib/admin/templates/admin/pagination.html` which was rendered
via the `pagination_tag` inside the `pagination` template block
Since the recent accessibility changes, the save button is no longer in
`django/contrib/admin/templates/admin/pagination.html` but is still in the
pagination template block

Given that when folks were overriding the pagination block before they
would have had to have handled the save button, I think what we have
currently is the most backwards compatible
--
Ticket URL: <https://code.djangoproject.com/ticket/36512#comment:4>

[Django]

#36512: The range of the pagination block on the admin ChangeList page is
incorrect.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution: invalid
Keywords: changelist, | Triage Stage:
pagination | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Antoliny):

Replying to [comment:4 Sarah Boyce]:

> Previously the save button was included in
`django/contrib/admin/templates/admin/pagination.html` which was rendered
via the `pagination_tag` inside the `pagination` template block
> Since the recent accessibility changes, the save button is no longer in
`django/contrib/admin/templates/admin/pagination.html` but is still in the
pagination template block
>
> Given that when folks were overriding the pagination block before they
would have had to have handled the save button, I think what we have
currently is the most backwards compatible

Ah, I hadn’t considered that.
Now that I think about it, to maintain backwards compatibility, it does
make sense to keep the current structure since the input button was
previously included within the pagination block.
--
Ticket URL: <https://code.djangoproject.com/ticket/36512#comment:5>