Re: [Django] #5899: Allow admin fieldsets to be collapsible but not initially collapsed

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut | Owner: nobody
Ciocirlan <ionut.ciocirlan@…> | Status: new
Type: New | Component: contrib.admin
feature | Severity: Normal
Milestone: | Keywords: admin fieldset
Version: newforms- | collapsed collapsible nfa-someday
admin | Has patch: 1
Resolution: | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by patchhammer):

* needs_better_patch: 0 => 1
* easy: => 0

Comment:

django_newforms-admin.collapsible_fieldset.diff fails to apply cleanly on
to trunk

--
Ticket URL: <http://code.djangoproject.com/ticket/5899#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------

Reporter: Ionut | Owner: dArignac
Ciocirlan <ionut.ciocirlan@…> | Status: assigned

Type: New | Component: contrib.admin
feature | Severity: Normal
Milestone: | Keywords: admin fieldset
Version: newforms- | collapsed collapsible nfa-someday
admin | Has patch: 1
Resolution: | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |

UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by dArignac):

* status: new => assigned
* owner: nobody => dArignac

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:7>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut | Owner: dArignac
Ciocirlan <ionut.ciocirlan@…> | Status: assigned
Type: New | Component: contrib.admin
feature | Severity: Normal
Milestone: | Keywords: admin fieldset
Version: newforms- | collapsed collapsible nfa-someday
admin | Has patch: 1
Resolution: | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |

Patch needs improvement: 0 |

UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by dArignac):

* needs_better_patch: 1 => 0

Comment:

I implemented the suggested behaviour to the current trunk, see 5899.diff.

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:8>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut | Owner: dArignac
Ciocirlan <ionut.ciocirlan@…> | Status: assigned
Type: New | Component: contrib.admin
feature | Severity: Normal
Milestone: | Keywords: admin fieldset
Version: newforms- | collapsed collapsible nfa-someday
admin | Has patch: 1
Resolution: | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by julien):

The patch looks great, I've just updated it to current trunk. I'd be
tempted to RFC this patch even if it doesn't contain tests. There are no
plans on implementing a framework for testing the admin *interface* (as
opposed to regular javascript code) clearly spelled out yet, even in
#16193.

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:9>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------

Reporter: Ionut Ciocirlan | Owner: dArignac
<ionut.ciocirlan@…> | Status: assigned
Type: New feature | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by jezdez):

* needs_tests: 0 => 1

Comment:

Now that we have selenium based interface testing this patch could be
expanded with that.

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:10>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner: dArignac
<ionut.ciocirlan@…> |

Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-

| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by collinanderson):

* cc: cmawebsite@… (added)

Comment:

Why not simply have all fieldsets collapsable by default and only have
them initially collapsed when the "collapse" class is present?

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:11>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner: dArignac
<ionut.ciocirlan@…> |
Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-
| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by olivierdalang):

* cc: olivier.dalang@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:12>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------

Reporter: Ionut Ciocirlan | Owner: (none)
<ionut.ciocirlan@…> |
Type: New feature | Status: new

Component: contrib.admin | Version: newforms-
| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* owner: Alexander Herrmann => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:13>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner:

<ionut.ciocirlan@…> | poncelettheo

Type: New feature | Status: assigned

Component: contrib.admin | Version: newforms-
| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by poncelettheo):

* owner: (none) => poncelettheo

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:14>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner:
<ionut.ciocirlan@…> | poncelettheo
Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-
| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by poncelettheo):

* easy: 0 => 1
* needs_tests: 1 => 0


Old description:

> I want to use the collapse feature of the admin, but not have the field
> initially collapsed, so I made this little patch.
>
> It adds a "collapsible" class that does just that. It also patches the
> documentation.

New description:

I want to use the collapse feature of the admin, but not have the field
initially collapsed, so I made this little patch.

It adds a "collapse-open" class that does just that. It also patches the
documentation.

--
--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:15>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner:
<ionut.ciocirlan@…> | poncelettheo
Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-
| admin
Severity: Normal | Resolution:
Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:16>

[Django]

#5899: Allow admin fieldsets to be collapsible but not initially collapsed
-------------------------------------+-------------------------------------
Reporter: Ionut Ciocirlan | Owner:
<ionut.ciocirlan@…> | poncelettheo

Type: New feature | Status: closed

Component: contrib.admin | Version: newforms-
| admin

Severity: Normal | Resolution: wontfix

Keywords: admin fieldset | Triage Stage: Accepted
collapsed collapsible nfa-someday |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* resolution: => wontfix
* status: assigned => closed

Comment:

Agreement that before we add this feature, this should be proposed on the
[https://github.com/orgs/django/projects/24/ New Features tracker] to
confirm there is appetite to add this in Django.
--
Ticket URL: <https://code.djangoproject.com/ticket/5899#comment:17>