Re: [Django] #36312: dark_mode.css has invalid size units for svg in Safari

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* owner: cwiegand => Ahmed Nassar
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:7>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* cc: Fabian Braun (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:8>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Fabian Braun):

* needs_better_patch: 0 => 1

Comment:

Besides within the CSS, the `width="1.5rem"` etc. are part of the
`base.html` template. The current patch does not remove the error messages
on the Safari console for me when testing locally. Can you take a look at
those, too?
--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:9>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ahmed Nassar):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:10>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:11>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ahmed Nassar):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:12>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: admin css | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:13>

[Django]

#36312: dark_mode.css has invalid size units for svg in Safari
-------------------------------------+-------------------------------------
Reporter: Christian Wiegand | Owner: Ahmed
Type: | Nassar

Cleanup/optimization | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: admin css | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"fbdbccf27a7d969a92e6ab8d2b7754e21e69b050" fbdbccf2]:
{{{#!CommitTicketReference repository=""
revision="fbdbccf27a7d969a92e6ab8d2b7754e21e69b050"
Fixed #36312 -- Removed invalid size units for svg in Safari.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36312#comment:14>