Re: [Django] #36331: Object tools moved out of content block breaks custom admin templates

[Django]

#36331: Object tools moved out of content block breaks custom admin templates
-------------------------------+--------------------------------------
Reporter: Fabian Braun | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Antoliny):

* cc: Antoliny (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36331: Object tools moved out of content block breaks custom admin templates

---------------------------------+------------------------------------

Reporter: Fabian Braun | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2

Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------
Changes (by Sarah Boyce):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

Comment:

Thank you for the report!
I agree this is not intended, at the very least we would need a note in
the breaking changes of 5.2.

Regression in b1324a680add78de24c763911d0eefa19b9263bc (refs #36055).
One option is to revert b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9 which I'm open to (then re-open
#36055).
Antoliny can you take a look?
--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:4>

[Django]

#36331: Object tools moved out of content block breaks custom admin templates
---------------------------------+------------------------------------

Reporter: Fabian Braun | Owner: Antoliny
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------

Changes (by Antoliny):

* owner: (none) => Antoliny
* status: new => assigned

Comment:

Replying to [comment:4 Sarah Boyce]:

> Thank you for the report!
> I agree this is not intended, at the very least we would need a note in
the breaking changes of 5.2.
>
> Regression in b1324a680add78de24c763911d0eefa19b9263bc (refs #36055).
> One option is to revert b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9 which I'm open to (then re-open
#36055).
> Antoliny can you take a look?

Sure sarahboyce! I'll take a look. and thank you Fabian Braun :)
--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:5>

[Django]

#36331: Object tools moved out of content block breaks custom admin templates
---------------------------------+------------------------------------
Reporter: Fabian Braun | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/19389 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:6>

[Django]

#36331: Object tools moved out of content block breaks custom admin templates

-------------------------------------+-------------------------------------

Reporter: Fabian Braun | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:7>

[Django]

#36331: Object tools moved out of content block breaks custom admin templates
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"1bc805e23b73a580b82a1d416ab0fb59a1073047" 1bc805e]:
{{{#!CommitTicketReference repository=""
revision="1bc805e23b73a580b82a1d416ab0fb59a1073047"
Fixed #36331 -- Reverted "Fixed #36055 -- Prevented overlap of object-
tools buttons and page header in the admin."

This reverts commits b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9. The former caused a regression
in admin sites that relied on the `object-tools` block being inside the
`content` block.

Thank you to Fabian Braun for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:8>

[Django]

#36331: Object tools moved out of content block breaks custom admin templates
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Antoliny
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"97c93549fc864af61cb1ae1fd171a3c7ac6ee89a" 97c9354]:
{{{#!CommitTicketReference repository=""
revision="97c93549fc864af61cb1ae1fd171a3c7ac6ee89a"
[5.2.x] Fixed #36331 -- Reverted "Fixed #36055 -- Prevented overlap of
object-tools buttons and page header in the admin."

This reverts commits b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9. The former caused a regression
in admin sites that relied on the `object-tools` block being inside the
`content` block.

Thank you to Fabian Braun for the report.

Backport of 1bc805e23b73a580b82a1d416ab0fb59a1073047 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36331#comment:9>