Re: [Django] #36269: Document overriding STORAGES for tests when using callable storage in a FileField

20 views
Skip to first unread message

Django

unread,
Mar 24, 2025, 10:45:07 AM3/24/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Accepted
storages |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* owner: (none) => Ahmed Nassar
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 6, 2025, 2:53:00 AM4/6/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Accepted
storages |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:4>

Django

unread,
Apr 6, 2025, 1:37:45 PM4/6/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Accepted
storages |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Ahmed Nassar):

All docs tests passed correctly in my local but in the pr get failed. why?
--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:5>

Django

unread,
Apr 11, 2025, 3:35:13 AM4/11/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Accepted
storages |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:6>

Django

unread,
Apr 14, 2025, 6:37:12 AM4/14/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Accepted
storages |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:7>

Django

unread,
Apr 14, 2025, 6:37:41 AM4/14/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Ready for
storages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahmed Nassar):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:8>

Django

unread,
Apr 14, 2025, 7:39:27 AM4/14/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Ready for
storages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce):

(You shouldn't mark you're own ticket as ready for checkin, however, I was
now about to do so so it ok. In future, you shouldn't do this)
--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:9>

Django

unread,
Apr 14, 2025, 7:52:38 AM4/14/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: assigned
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution:
Keywords: override_settings, | Triage Stage: Ready for
storages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Ahmed Nassar):

Okay. I'll don't make it again.
--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:10>

Django

unread,
Apr 15, 2025, 4:06:10 AM4/15/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: closed
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: override_settings, | Triage Stage: Ready for
storages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"8bca33f68acc4fc881146c4b9cf4101a8bfab437" 8bca33f6]:
{{{#!CommitTicketReference repository=""
revision="8bca33f68acc4fc881146c4b9cf4101a8bfab437"
Fixed #36269 -- Documented how to test callable storage in FileField.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:11>

Django

unread,
Apr 15, 2025, 4:11:52 AM4/15/25
to django-...@googlegroups.com
#36269: Document overriding STORAGES for tests when using callable storage in a
FileField
-------------------------------------+-------------------------------------
Reporter: emillumine | Owner: Ahmed
Type: | Nassar
Cleanup/optimization | Status: closed
Component: File | Version: 5.1
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: override_settings, | Triage Stage: Ready for
storages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"cbdb1bed041a88a5e29cab5e60da928b2d9e6db5" cbdb1be]:
{{{#!CommitTicketReference repository=""
revision="cbdb1bed041a88a5e29cab5e60da928b2d9e6db5"
[5.2.x] Fixed #36269 -- Documented how to test callable storage in
FileField.

Backport of 8bca33f68acc4fc881146c4b9cf4101a8bfab437 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36269#comment:12>
Reply all
Reply to author
Forward
0 new messages