[Django] #36283: Filtering sidebar jump out of context when navigation sidebar is visible.

33 views
Skip to first unread message

Django

unread,
Mar 31, 2025, 4:55:32 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz | Owner: Mariusz Felisiak
Felisiak |
Type: Bug | Status: assigned
Component: | Version: 5.2
contrib.admin |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
When both filter sidebar and navigation sidebar are visible and table
needs a horizontal sidebar, width of elements are not calculated properly.
For example:
- Django 5.1

- Django 5.2



Regression 747b417a220b0412ed806001a383959449aac6da. I think we should
revert this commit.
--
Ticket URL: <https://code.djangoproject.com/ticket/36283>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 31, 2025, 4:55:43 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Django_51.png" added.

Django

unread,
Mar 31, 2025, 4:56:28 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Django_52.png" added.

Django

unread,
Mar 31, 2025, 4:56:50 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* severity: Normal => Release blocker

--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:1>

Django

unread,
Mar 31, 2025, 4:59:44 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Mariusz Felisiak:

Old description:

> When both filter sidebar and navigation sidebar are visible and table
> needs a horizontal sidebar, width of elements are not calculated
> properly. For example:
> - Django 5.1
>
> - Django 5.2
>

>
> Regression 747b417a220b0412ed806001a383959449aac6da. I think we should
> revert this commit.

New description:

When both filter sidebar and navigation sidebar are visible and table
needs a horizontal sidebar, width of elements are not calculated properly.
For example:

- Django 5.1

[[Image(Django_51.png, width=85em)]]

- Django 5.2


[[Image(Django_52.png, width=85em)]]

Regression 747b417a220b0412ed806001a383959449aac6da. I think we should
revert this commit.

--
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:2>

Django

unread,
Mar 31, 2025, 5:04:16 PM3/31/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/19324 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:3>

Django

unread,
Apr 1, 2025, 3:19:20 AM4/1/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Sarah Boyce:

Old description:

> When both filter sidebar and navigation sidebar are visible and table
> needs a horizontal sidebar, width of elements are not calculated
> properly. For example:
>
> - Django 5.1
>
> [[Image(Django_51.png, width=85em)]]
>
> - Django 5.2
>

> [[Image(Django_52.png, width=85em)]]
>
> Regression 747b417a220b0412ed806001a383959449aac6da. I think we should
> revert this commit.

New description:

When both filter sidebar and navigation sidebar are visible and table
needs a horizontal scrollbar, width of elements are not calculated
properly. For example:

- Django 5.1

[[Image(Django_51.png, width=85em)]]

- Django 5.2


[[Image(Django_52.png, width=85em)]]

Regression 747b417a220b0412ed806001a383959449aac6da. I think we should
revert this commit.

--
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:4>

Django

unread,
Apr 1, 2025, 3:19:51 AM4/1/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

Comment:

Well spotted thank you
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:5>

Django

unread,
Apr 1, 2025, 3:23:53 AM4/1/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:6>

Django

unread,
Apr 1, 2025, 3:30:52 AM4/1/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"12385b4fa7059aab8e4f671853cc09ae8509501f" 12385b4f]:
{{{#!CommitTicketReference repository=""
revision="12385b4fa7059aab8e4f671853cc09ae8509501f"
Fixed #36283 -- Reverted "Fixed #35798, Refs #31641 -- Prevented admin
navigation sidebar loading flicker."

This reverts commit 747b417a220b0412ed806001a383959449aac6da that caused
a visual regression when both navigation and filter sidebars are
visible.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:7>

Django

unread,
Apr 1, 2025, 3:33:15 AM4/1/25
to django-...@googlegroups.com
#36283: Filtering sidebar jump out of context when navigation sidebar is visible.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"88ca180bfe9940e338b5d4eca5079fd2280c752c" 88ca180b]:
{{{#!CommitTicketReference repository=""
revision="88ca180bfe9940e338b5d4eca5079fd2280c752c"
[5.2.x] Fixed #36283 -- Reverted "Fixed #35798, Refs #31641 -- Prevented
admin navigation sidebar loading flicker."

This reverts commit 747b417a220b0412ed806001a383959449aac6da that caused
a visual regression when both navigation and filter sidebars are
visible.

Backport of 12385b4fa7059aab8e4f671853cc09ae8509501f from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36283#comment:8>
Reply all
Reply to author
Forward
0 new messages