Re: [Django] #36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used renderer

11 views
Skip to first unread message

Django

unread,
Mar 14, 2025, 10:21:30 AM3/14/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Ahmed Nassar):

* owner: (none) => Ahmed Nassar
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 14, 2025, 2:46:17 PM3/14/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Ahmed Nassar):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:3>

Django

unread,
Mar 14, 2025, 2:48:33 PM3/14/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Comment (by Ahmed Nassar):

✅ Update on RelatedFieldWidgetWrapper Renderer Fix

I have submitted a PR to ensure `RelatedFieldWidgetWrapper.get_context()`
correctly respects the provided renderer.

🔹 Fixes:

Added an optional renderer parameter.
Ensured the underlying widget uses the correct renderer.
Maintained full backward compatibility.
All tests passed successfully.

📌 The PR is ready for review. Let me know if any changes are needed!

🔗 PR: https://github.com/django/django/pull/19271
--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:4>

Django

unread,
Mar 17, 2025, 6:27:03 AM3/17/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:5>

Django

unread,
Mar 17, 2025, 8:14:59 PM3/17/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Ahmed Nassar):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:6>

Django

unread,
Mar 18, 2025, 4:33:16 AM3/18/25
to django-...@googlegroups.com
#36250: admin.widgets.RelatedFieldWidgetWrapper.get_context() bypasses the used
renderer
-------------------------------+----------------------------------------
Reporter: Jacob Rief | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36250#comment:7>
Reply all
Reply to author
Forward
0 new messages