Re: [Django] #35945: Add async interface to Paginator

52 views
Skip to first unread message

Django

unread,
Nov 29, 2024, 4:43:57 AM11/29/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: (none)
Type: New feature | Status: new
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by wookkl):

Hello, would it be okay if I contributed to this new feature?
--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:2>
Django <https://code.djangoproject.com/>
The web framework for perfectionists with deadlines.

Django

unread,
Nov 29, 2024, 4:49:43 AM11/29/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by wookkl):

* owner: (none) => wookkl
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:3>

Django

unread,
Dec 16, 2024, 1:56:40 AM12/16/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by wookkl):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 16, 2024, 3:24:07 AM12/16/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1
* needs_docs: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:5>

Django

unread,
Dec 29, 2024, 2:43:18 AM12/29/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by wookkl):

Replying to [comment:5 Sarah Boyce]:

I have refactored code based on your feedback and prepared docs and
release notes. Please review them.😀
--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:6>

Django

unread,
Dec 29, 2024, 4:11:15 AM12/29/24
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 1 => 0
* needs_docs: 1 => 0

Comment:

Thanks for the update. (You can unset these checkboxes yourself when
you've finished addressing feedback.)
--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:7>

Django

unread,
Jan 2, 2025, 6:48:45 AM1/2/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:8>

Django

unread,
Jan 10, 2025, 8:36:25 AM1/10/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:9>

Django

unread,
Jan 13, 2025, 11:41:36 AM1/13/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:10>

Django

unread,
Jan 16, 2025, 9:44:31 AM1/16/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by wookkl):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:11>

Django

unread,
Feb 26, 2025, 6:23:59 AM2/26/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:12>

Django

unread,
Mar 9, 2025, 8:49:30 AM3/9/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by wookkl):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:13>

Django

unread,
Mar 10, 2025, 4:17:48 AM3/10/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:14>

Django

unread,
Mar 11, 2025, 11:58:46 AM3/11/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Accepted
SynchronousOnlyOperation |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by wookkl):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:15>

Django

unread,
Mar 11, 2025, 12:26:23 PM3/11/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: assigned
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution:
Keywords: Paginator, async, | Triage Stage: Ready for
SynchronousOnlyOperation | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:16>

Django

unread,
Mar 12, 2025, 4:22:58 AM3/12/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: closed
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: Paginator, async, | Triage Stage: Ready for
SynchronousOnlyOperation | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"2ae3044d9d4dfb8371055513e440e0384f211963" 2ae3044d]:
{{{#!CommitTicketReference repository=""
revision="2ae3044d9d4dfb8371055513e440e0384f211963"
Fixed #35945 -- Added async interface to Paginator.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:17>

Django

unread,
Jul 9, 2025, 12:01:59 PM7/9/25
to django-...@googlegroups.com
#35945: Add async interface to Paginator
-------------------------------------+-------------------------------------
Reporter: smiling-watermelon | Owner: wookkl
Type: New feature | Status: closed
Component: Core (Other) | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: Paginator, async, | Triage Stage: Ready for
SynchronousOnlyOperation | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):

In [changeset:"426be74022ec31d571858a5b8155300c07a4bdbf" 426be740]:
{{{#!CommitTicketReference repository=""
revision="426be74022ec31d571858a5b8155300c07a4bdbf"
Refs #35844, #35945 -- Used asgiref.sync.iscoroutinefunction() instead of
deprecated asyncio.iscoroutinefunction().

Follow up to bd3b1dfa2422e02ced3a894adb7544e42540c97d.
Introduced in 2ae3044d9d4dfb8371055513e440e0384f211963.

Fixes DeprecationWarning:

'asyncio.iscoroutinefunction' is deprecated and slated for removal
in Python 3.16; use inspect.iscoroutinefunction() instead.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35945#comment:18>
Reply all
Reply to author
Forward
0 new messages