Re: [Django] #36178: Consistent quoting of object strings in admin delete confirmation messages.

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.
--------------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: delete | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.
--------------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: dev

Severity: Normal | Resolution:
Keywords: delete | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* version: 5.1 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:4>

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.
--------------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: delete | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:5>

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.

-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: delete | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Raphael Gaschignard):

* stage: Accepted => Ready for checkin

Comment:

Think there have been a good number of eyes on this, and I didn't find any
other potential-smart-quote-needing spots.
--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:6>

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.

--------------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: delete | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1

--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

* stage: Ready for checkin => Accepted

Comment:

I think we should also update translations as part of the change similar
to 42b9a23267f14be39b9b00958e18d5746783208e (#30400)
--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:7>

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.

-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: delete | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:8>

[Django]

#36178: Consistent quoting of object strings in admin delete confirmation messages.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: dev

Severity: Normal | Resolution: fixed

Keywords: delete | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"2fa1f99ab49ae5b6bc0a15ed9398d6fa2996f02a" 2fa1f99]:
{{{#!CommitTicketReference repository=""
revision="2fa1f99ab49ae5b6bc0a15ed9398d6fa2996f02a"
Fixed #36178 -- Applied consistent object quoting in admin delete
confirmation page.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36178#comment:9>