[Django] #36156: test_db_default_output_field_resolving errors on databases that do not support JSONField.

21 views
Skip to first unread message

Django

unread,
Jan 28, 2025, 8:14:19 PMJan 28
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage | Owner: Sage Abdullah
Abdullah |
Type: | Status: assigned
Cleanup/optimization |
Component: Testing | Version: dev
framework |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Running
[https://github.com/django/django/blob/8a6b4175d790424312965ec77e4e9b072fba188b/tests/schema/tests.py#L2425-L2443
schema.tests.SchemaTests.test_db_default_output_field_resolving] fails on
databases that do not support JSONField, as it's missing a
`@skipUnlessDBFeature("supports_json_field")` decorator.

See https://github.com/django/django-docker-
box/pull/50#discussion_r1933066031 for more details.
--
Ticket URL: <https://code.djangoproject.com/ticket/36156>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 29, 2025, 12:11:40 AMJan 29
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Sage
Type: | Abdullah
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:1>

Django

unread,
Jan 29, 2025, 12:38:01 AMJan 29
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Sage
Type: | Abdullah
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:2>

Django

unread,
Jan 29, 2025, 9:20:55 AMJan 29
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Sage
Type: | Abdullah
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sage Abdullah):

Given the low-severity of the ticket and simpleness of the fix, I'm
considering "reserving" this for the Djangonaut Space program. I'll be a
navigator for the next session, which starts in ~a couple of weeks.

I hope that's OK. If anybody's not happy with it, let me know 😬
--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:3>

Django

unread,
Jan 29, 2025, 10:59:36 AMJan 29
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Sage
Type: | Abdullah
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):

That sounds like a great idea Sage. Not sure if you want to claim
ownership in the mean time to avoid causing confusion. It's not unusual
for avid contributors to assign themselves "easy picking" tickets without
reading the full context of the issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:4>

Django

unread,
Jan 29, 2025, 11:07:59 AMJan 29
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Sage
Type: | Abdullah
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sage Abdullah):

Thank you for the confirmation Simon! I already assigned the ticket when I
created it 😄
--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:5>

Django

unread,
Feb 19, 2025, 3:02:29 PMFeb 19
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
--------------------------------------+------------------------------------
Reporter: Sage Abdullah | Owner: cKelvin
Type: Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by cKelvin):

* owner: Sage Abdullah => cKelvin

--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:6>

Django

unread,
Apr 5, 2025, 12:52:07 PMApr 5
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Kelvin
Type: | Adigwu
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin

Comment:

[https://github.com/django/django/pull/19345 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:7>

Django

unread,
Apr 5, 2025, 12:54:20 PMApr 5
to django-...@googlegroups.com
#36156: test_db_default_output_field_resolving errors on databases that do not
support JSONField.
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: Kelvin
Type: | Adigwu
Cleanup/optimization | Status: closed
Component: Testing framework | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"25f97e7bcf2e5064258e07b970b4bdef5fddce51" 25f97e7b]:
{{{#!CommitTicketReference repository=""
revision="25f97e7bcf2e5064258e07b970b4bdef5fddce51"
Fixed #36156 -- Added supports_json_field check in
test_db_default_output_field_resolving test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36156#comment:8>
Reply all
Reply to author
Forward
0 new messages