[Django] #34355: Make BaseConstraint arguments keyword-only

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: dev
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
As suggested in
https://github.com/django/django/pull/16560#pullrequestreview-1305496392

> I think we should change the signature of BaseConstraint to use keyword-
only arguments as a separate cleanup

`name` and `violation_error_message` are already keyword-only in all the
`BaseConstraint` subclasses in Django code base.

--
Ticket URL: <https://code.djangoproject.com/ticket/34355>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------

Reporter: xafer | Owner: xafer
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by xafer):

* owner: nobody => xafer
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:1>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by xafer):

* has_patch: 0 => 1

Comment:

Cf [https://github.com/django/django/pull/16578 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:2>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:3>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:4>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:5>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer

Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"ad18a0102cc2968914232814c6554763f15abbe3" ad18a010]:
{{{
#!CommitTicketReference repository=""
revision="ad18a0102cc2968914232814c6554763f15abbe3"
Fixed #34355 -- Deprecated passing positional arguments to BaseConstraint.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:6>

[Django]

#34355: Make BaseConstraint arguments keyword-only
-------------------------------------+-------------------------------------
Reporter: xafer | Owner: xafer
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"b5a6c93a180e2c213e42f30a30bf63548a248957" b5a6c93a]:
{{{#!CommitTicketReference repository=""
revision="b5a6c93a180e2c213e42f30a30bf63548a248957"
Refs #34355 -- Removed support for positional arguments in BaseConstraint
per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34355#comment:7>