Re: [Django] #36080: Cleanup the inline link format.

[Django]

#36080: Cleanup the inline link format.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Inline, Link | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Antoliny):

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36080#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36080: Cleanup the inline link format.

-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Inline, Link | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Antoliny):

* type: New feature => Cleanup/optimization

--
Ticket URL: <https://code.djangoproject.com/ticket/36080#comment:7>

[Django]

#36080: Cleanup the inline link format.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny

Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: dev

Severity: Normal | Resolution: wontfix

Keywords: Inline, Link | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* resolution: => wontfix
* status: assigned => closed

Comment:

Could you raise this on the [https://forum.djangoproject.com/c/internals/5
forum]?
I think the change/view link pattern exists in a few places and we should
check each of them together to complete the proposal.

We should be clear when that patter should be used vs applying a link to
the string. The accessibility team should also consider this. I would say
right now the buttons are always the same size regardless of the size of
`__str__` but this could return "-" or possibly even a blank string which
would not be clickable

I also don't like that the stacked inline has the model name prefix but
the tabular does not
--
Ticket URL: <https://code.djangoproject.com/ticket/36080#comment:8>

[Django]

#36080: Cleanup the inline link format.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: Inline, Link | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Antoliny):

Hmm.. You're right. We need to consider cases where the `__str__` method
returns elements like "-" or an empty string when applying a link.
I also previously mentioned the difference between `Stacked Inline` and
`Tabular Inline` headers in another issue.
I don't understand why the headers for these two features are different
either. Considering the issue raised in
[https://code.djangoproject.com/ticket/36079 ticket_36079], I feel that
changes to the `Tabular Inline` and `Stacked Inline` headers are
necessary. Thank you, Sarah Boyce! I will write a post about this on the
Django forum internals.
--
Ticket URL: <https://code.djangoproject.com/ticket/36080#comment:9>

[Django]

#36080: Cleanup the inline link format.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: Inline, Link | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Antoliny):

[https://forum.djangoproject.com/t/improving-consistency-and-
accessibility-between-tabularinline-and-stackedinline/37951 discussion]
--
Ticket URL: <https://code.djangoproject.com/ticket/36080#comment:10>