Re: [Django] #36069: The position of the "X" button for the InlineForm in TabularInline differs depending on the can_delete value.

19 views
Skip to first unread message

Django

unread,
Jan 7, 2025, 6:29:06 AM1/7/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Antoliny):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 7, 2025, 6:29:21 AM1/7/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+--------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by Antoliny):

[https://github.com/django/django/pull/19010 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:4>

Django

unread,
Jan 7, 2025, 7:04:07 AM1/7/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted

Comment:

Thank you Antoliny! I reproduced in latest main, accepting.
--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:5>

Django

unread,
Jan 8, 2025, 8:06:16 AM1/8/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Natalia Bidart):

* needs_tests: 0 => 1

Comment:

Code-wise the PR looks good, I asked for a minimal test to ensure no
regressions occur in the template.
--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:6>

Django

unread,
Jan 11, 2025, 5:44:34 AM1/11/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Antoliny):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:7>

Django

unread,
Jan 30, 2025, 8:31:49 AM1/30/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Sarah Boyce):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:8>

Django

unread,
Jan 31, 2025, 4:34:46 AM1/31/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------+------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Antoliny):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:9>

Django

unread,
Feb 3, 2025, 7:09:37 AM2/3/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: TabularInline | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:10>

Django

unread,
Feb 4, 2025, 2:56:32 AM2/4/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: TabularInline | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"1330cb570519170bb4397b4fb02c7e3e0657855a" 1330cb5]:
{{{#!CommitTicketReference repository=""
revision="1330cb570519170bb4397b4fb02c7e3e0657855a"
Fixed #36069 -- Fixed the delete button position in TabularInlines.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:11>

Django

unread,
Feb 4, 2025, 2:58:00 AM2/4/25
to django-...@googlegroups.com
#36069: The position of the "X" button for the InlineForm in TabularInline differs
depending on the can_delete value.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Antoliny
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: TabularInline | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"209d0f6143739df8583adb7e93856ad3584c9fdb" 209d0f61]:
{{{#!CommitTicketReference repository=""
revision="209d0f6143739df8583adb7e93856ad3584c9fdb"
[5.2.x] Fixed #36069 -- Fixed the delete button position in
TabularInlines.

Backport of 1330cb570519170bb4397b4fb02c7e3e0657855a from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36069#comment:12>
Reply all
Reply to author
Forward
0 new messages