[Django] #36052: Add support for CompositePrimaryKey in inspectdb

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob | Owner: Jacob Walls
Walls |
Type: New | Status: assigned
feature |
Component: Core | Version: dev
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
We can now replace the
[https://github.com/django/django/blob/8d9901c961bf9d5cfa6bddddbbcebfbf487a5125/django/core/management/commands/inspectdb.py#L155-L159
half-measure] created when introspecting a composite primary key with the
actual field.

[https://github.com/django/django/pull/18986 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/36052>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------

Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: assigned
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:1>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: assigned
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:2>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls

Type: New feature | Status: closed

Component: Core (Management | Version: dev
commands) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"a8e4fd11efc65832e7d9f5582d3868c5c8bd8d88" a8e4fd11]:
{{{#!CommitTicketReference repository=""
revision="a8e4fd11efc65832e7d9f5582d3868c5c8bd8d88"
Fixed #36052 -- Supported CompositePrimaryKey in inspectdb.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:3>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by nessita <124304+nessita@…>):

In [changeset:"4c75858135589f3a00e32eb4d476074536371a32" 4c758581]:
{{{#!CommitTicketReference repository=""
revision="4c75858135589f3a00e32eb4d476074536371a32"
Refs #36052, #32234 -- Removed
create_test_table_with_composite_primary_key flag in favor of using
CompositePrimaryKey.

Now that Django properly supports creating models with composite primary
keys, the tests should use a `CompositePrimaryKey` field instead of a
feature flag to inline backend specific SQL for creating a composite PK.

Specifcially, the inspectdb's test_composite_primary_key was adjusted to
use schema editor instead of per-backend raw SQL.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:4>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"5d03c71b7a2256e776f134a7844c95f0f8f06c6d" 5d03c71b]:
{{{#!CommitTicketReference repository=""
revision="5d03c71b7a2256e776f134a7844c95f0f8f06c6d"
[5.2.x] Refs #36052, #32234 -- Removed

create_test_table_with_composite_primary_key flag in favor of using
CompositePrimaryKey.

Now that Django properly supports creating models with composite primary
keys, the tests should use a `CompositePrimaryKey` field instead of a
feature flag to inline backend specific SQL for creating a composite PK.

Specifcially, the inspectdb's test_composite_primary_key was adjusted to
use schema editor instead of per-backend raw SQL.

Backport of 4c75858135589f3a00e32eb4d476074536371a32 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:5>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"dd133054cb98f77577c06d7ef1f2391a865784bc" dd133054]:
{{{#!CommitTicketReference repository=""
revision="dd133054cb98f77577c06d7ef1f2391a865784bc"
Refs #36052, #32234 -- Fixed inspectdb tests for CompositePrimaryKey on
Oracle.

Tests regression in 4c75858135589f3a00e32eb4d476074536371a32.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:6>

[Django]

#36052: Add support for CompositePrimaryKey in inspectdb
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: New feature | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"44bda7a6740b60eb72b59dc49a4c7f9a2816cdbf" 44bda7a6]:
{{{#!CommitTicketReference repository=""
revision="44bda7a6740b60eb72b59dc49a4c7f9a2816cdbf"
[5.2.x] Refs #36052, #32234 -- Fixed inspectdb tests for

CompositePrimaryKey on Oracle.

Tests regression in 4c75858135589f3a00e32eb4d476074536371a32.

Backport of dd133054cb98f77577c06d7ef1f2391a865784bc from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36052#comment:7>