Re: [Django] #36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code comments refer to "headers" rather than request.META keys

[Django]

#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner:
Type: | devian-321
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
RemoteUserMiddleware, |
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by devian-321):

* owner: Anders Einar Hilden => devian-321
* status: new => assigned

Comment:

Hi, This is my first time trying to contribute and I would like to work on
this ticket to get familiar with. I currently am not familiar with the
methods and the ticketing system, So i might be prone to making beginners
mistakes in the protocol. Appreciate the understanding
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner:
Type: | devian-321
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
RemoteUserMiddleware, |
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Anders Einar Hilden):

Welcome devian-321- while i created this ticket, I have also created a PR
for resolving it (linked) - i have just not been able to incorporate the
comments from the PR discussion yet.

I would reccommend looking at another ticket :)
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:10>

[Django]

#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------

Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden

Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
RemoteUserMiddleware, |
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* owner: devian-321 => Anders Einar Hilden

--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:11>

[Django]

#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
RemoteUserMiddleware, | checkin

PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:12>

[Django]

#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden

Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
RemoteUserMiddleware, | checkin
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"a8b70aeffd41d082d4bd8f99c777f37b6a58da66" a8b70aef]:
{{{#!CommitTicketReference repository=""
revision="a8b70aeffd41d082d4bd8f99c777f37b6a58da66"
Fixed #36002 -- Referred to request.Meta key in
Persistent/RemoteUserMiddleware comments.

Changed the docstrings and code comments to better reflect where the
default value
comes from (an environment variable, not request header).
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:13>