[Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin
--------------------------------+-----------------------------------------
Reporter: tanaydin sirin | Type: New feature
Status: new | Component: contrib.admin
Version: 5.0 | Severity: Normal
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+-----------------------------------------
On any object list, we can select multiple objects by pressing the shift
key while clicking the second checkbox, but it's not possible with
TabularInline ModelAdmin.
--
Ticket URL: <https://code.djangoproject.com/ticket/35650>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin
--------------------------------+--------------------------------------

Reporter: tanaydin sirin | Owner: (none)

Type: New feature | Status: new
Component: contrib.admin | Version: 5.0

Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------

Changes (by tanaydin sirin):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:1>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin
--------------------------------+--------------------------------------
Reporter: tanaydin sirin | Owner: (none)
Type: New feature | Status: new

Component: contrib.admin | Version: 5.1

Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by tanaydin sirin):

* version: 5.0 => 5.1

Comment:

Fix at

https://github.com/django/django/pull/18438
--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:2>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin
--------------------------------+------------------------------------

Reporter: tanaydin sirin | Owner: (none)
Type: New feature | Status: new

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------

Changes (by Natalia Bidart):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
* version: 5.1 => dev

Comment:

Hello tanaydin sirin, thank you for your interest in making Django better.
I have reproduced the described issue, and I agree it would be good to
allow for shift-selecting in tabular admins just like in the changelist
page.

I took a quite look at your PR, and I was thinking that instead of
providing new javascript, we should try to re-use/generalize what the
changelist page is already using. Could you look into that?
--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:3>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

--------------------------------+------------------------------------------
Reporter: tanaydin sirin | Owner: tanaydin sirin
Type: New feature | Status: assigned

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0

--------------------------------+------------------------------------------
Changes (by Sarah Boyce):

* owner: (none) => tanaydin sirin
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:4>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin
--------------------------------+------------------------------------------
Reporter: tanaydin sirin | Owner: tanaydin sirin
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------

Comment (by tanaydin sirin):

Hello Natalia Bidart, I've made the changes. Shall I do anything else
about ticket?

Replying to [comment:3 Natalia Bidart]:

> Hello tanaydin sirin, thank you for your interest in making Django
better. I have reproduced the described issue, and I agree it would be
good to allow for shift-selecting in tabular admins just like in the
changelist page.
>
> I took a quite look at your PR, and I was thinking that instead of
providing new javascript, we should try to re-use/generalize what the
changelist page is already using. Could you look into that?

--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:5>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

-------------------------------------+-------------------------------------

Reporter: tanaydin sirin | Owner: tanaydin
| sirin
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by tanaydin sirin):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:12>

[Django]

#35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

--------------------------------+------------------------------------------

Reporter: tanaydin sirin | Owner: tanaydin sirin
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

--------------------------------+------------------------------------------
Changes (by Sarah Boyce):

* stage: Ready for checkin => Accepted

Comment:

You cannot mark your own contributions as "Ready for checkin".
This should be done by a community member after a review and approval. See
https://docs.djangoproject.com/en/5.1/internals/contributing/triaging-
tickets/#ready-for-checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/35650#comment:13>