[Django] #35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------------+-------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Keywords: geoip2, db-ip
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+-------------------------------
#33442 added support for using the DB-IP Lite databases.

According to [https://code.djangoproject.com/ticket/33442#comment:6 this
comment] this support has regressed.

Various changes were made in Django 5.1 to modernise
`django.contrib.gis.geoip2` and improve testing, but the support for DB-IP
Lite databases was missed as there were no tests for it, likely due to the
prior issues around shipping test databases that was resolved as part of
those changes.
--
Ticket URL: <https://code.djangoproject.com/ticket/35841>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2

---------------------------------+-------------------------------------

Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1

Severity: Release blocker | Resolution:
Keywords: geoip2, db-ip | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+-------------------------------------
Changes (by Nick Pope):

* stage: Unreviewed => Accepted

Comment:

Accepting as I'm migrating this from the original issue (where it has been
accepted) as per [https://code.djangoproject.com/ticket/33442#comment:12
this comment].
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:1>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
---------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: geoip2, db-ip | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------

Description changed by Nick Pope:

Old description:

> #33442 added support for using the DB-IP Lite databases.
>
> According to [https://code.djangoproject.com/ticket/33442#comment:6 this
> comment] this support has regressed.
>
> Various changes were made in Django 5.1 to modernise
> `django.contrib.gis.geoip2` and improve testing, but the support for DB-
> IP Lite databases was missed as there were no tests for it, likely due to
> the prior issues around shipping test databases that was resolved as part
> of those changes.

New description:

#33442 added support for using the DB-IP Lite databases.

According to [https://code.djangoproject.com/ticket/33442#comment:6 this
comment] this support has regressed.

Various changes were made in Django 5.1 to modernise
`django.contrib.gis.geoip2` and improve testing, but the support for DB-IP
Lite databases was missed as there were no tests for it, likely due to the
prior issues around shipping test databases that was resolved as part of
those changes.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

--
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:2>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
---------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: geoip2, db-ip | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------

Changes (by Nick Pope):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/18677 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:3>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2

-------------------------------------+-------------------------------------

Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:

Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:4>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope

Type: Bug | Status: closed
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"3fad712a91a8a8f6f6f904aff3d895e3b06b24c7" 3fad712a]:
{{{#!CommitTicketReference repository=""
revision="3fad712a91a8a8f6f6f904aff3d895e3b06b24c7"
Fixed #35841 -- Restored support for DB-IP databases in GeoIP2.

Thanks Felix Farquharson for the report and Claude Paroz for the
review.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Co-authored-by: Natalia <124304+...@users.noreply.github.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:7>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope

Type: Bug | Status: assigned

Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:

Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by nessita <124304+nessita@…>):

In [changeset:"c37f249ffa4b735d1492cda11981dedb947ee437" c37f249f]:
{{{#!CommitTicketReference repository=""
revision="c37f249ffa4b735d1492cda11981dedb947ee437"
Refs #35841 -- Updated GeoIP2 test database files.

The mmdb files were taken from
https://github.com/maxmind/MaxMind-
DB/commit/679e37e18a4a3009949c2213ec2c0bb8090c10c7.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:5>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by nessita <124304+nessita@…>):

In [changeset:"5873f10177ebda66d38e698218cf85dc6397e7d9" 5873f10]:
{{{#!CommitTicketReference repository=""
revision="5873f10177ebda66d38e698218cf85dc6397e7d9"
Refs #35841 -- Adjusted GeoIP2 tests for easier test case extension.

These changes will make it easier to introduce tests for alternate
databases that may have different results without the need to duplicate
lots of the tests definition.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:6>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope

Type: Bug | Status: closed
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"51eb666758840e0fca15414f1c5826bd20e31153" 51eb6667]:
{{{#!CommitTicketReference repository=""
revision="51eb666758840e0fca15414f1c5826bd20e31153"
[5.1.x] Fixed #35841 -- Restored support for DB-IP databases in GeoIP2.

Thanks Felix Farquharson for the report and Claude Paroz for the
review.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Co-authored-by: Natalia <124304+...@users.noreply.github.com>

Backport of 3fad712a91a8a8f6f6f904aff3d895e3b06b24c7 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:10>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: closed
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"d1b63c26cc7962f9401d1650572aeb838892ad55" d1b63c2]:
{{{#!CommitTicketReference repository=""
revision="d1b63c26cc7962f9401d1650572aeb838892ad55"
[5.1.x] Refs #35841 -- Updated GeoIP2 test database files.

The mmdb files were taken from
https://github.com/maxmind/MaxMind-
DB/commit/679e37e18a4a3009949c2213ec2c0bb8090c10c7.

Backport of c37f249ffa4b735d1492cda11981dedb947ee437 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:8>

[Django]

#35841: Regression of support for DB-IP databases in django.contrib.gis.geoip2
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: closed
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: geoip2, db-ip | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"434cf004b8613908508bee506eab67fbf2374c41" 434cf00]:
{{{#!CommitTicketReference repository=""
revision="434cf004b8613908508bee506eab67fbf2374c41"
[5.1.x] Refs #35841 -- Adjusted GeoIP2 tests for easier test case

extension.

These changes will make it easier to introduce tests for alternate
databases that may have different results without the need to duplicate
lots of the tests definition.

Backport of 5873f10177ebda66d38e698218cf85dc6397e7d9 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35841#comment:9>