Re: [Django] #35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails when bcachefs is in use

12 views
Skip to first unread message

Django

unread,
Sep 9, 2024, 10:32:59 AM9/9/24
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner: (none)
Type: Bug | Status: closed
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* resolution: => needsinfo
* status: new => closed

Comment:

Increasing the `max_length` for `extended_length` might work but I can't
find what this number should be for [https://bcachefs.org/ bcachefs].
{{{#!diff
--- a/tests/file_storage/models.py
+++ b/tests/file_storage/models.py
@@ -80,5 +80,5 @@ class Storage(models.Model):
storage=temp_storage, upload_to="tests", max_length=20
)
extended_length = models.FileField(
- storage=temp_storage, upload_to="tests", max_length=300
+ storage=temp_storage, upload_to="tests", max_length=2000
)
}}}

Can you share what `_storage_max_filename_length` returns for you?
--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 14, 2024, 4:30:30 AM10/14/24
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner: (none)
Type: Bug | Status: new
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Alyssa Ross):

* resolution: needsinfo =>
* status: closed => new

Comment:

Hi! Sorry, I missed the notification.

PC_NAME_MAX on bcachefs is 512.
--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:5>

Django

unread,
Oct 14, 2024, 4:53:52 AM10/14/24
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
--------------------------------------+------------------------------------
Reporter: Alyssa Ross | Owner: (none)
Type: Bug | Status: new
Component: File uploads/storage | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:6>

Django

unread,
Dec 14, 2024, 8:21:18 PM12/14/24
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner:
| YashRaj1506
Type: Bug | Status: assigned
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by YashRaj1506):

* owner: (none) => YashRaj1506
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:7>

Django

unread,
Dec 23, 2024, 7:05:23 PM12/23/24
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner:
| YashRaj1506
Type: Bug | Status: assigned
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by YashRaj1506):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:8>

Django

unread,
Jan 2, 2025, 10:30:23 AMJan 2
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner:
| YashRaj1506
Type: Bug | Status: assigned
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:9>

Django

unread,
Jan 3, 2025, 2:40:57 AMJan 3
to django-...@googlegroups.com
#35740: file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails
when bcachefs is in use
-------------------------------------+-------------------------------------
Reporter: Alyssa Ross | Owner:
| YashRaj1506
Type: Bug | Status: closed
Component: File | Version: 4.2
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"12f4f95405c7857cbf2f4bf4d0261154aac31676" 12f4f954]:
{{{#!CommitTicketReference repository=""
revision="12f4f95405c7857cbf2f4bf4d0261154aac31676"
Fixed #35740 -- Fixed FileFieldStorageTests.test_extended_length_storage
when using bcachefs.

PC_NAME_MAX on bcachefs is 512, which was greater than the file field
max_length.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35740#comment:10>
Reply all
Reply to author
Forward
0 new messages