Re: [Django] #35742: Avoid refering to "username" in admin templates as USERNAME_FIELD can be updated

8 views
Skip to first unread message

Django

unread,
Oct 8, 2024, 2:14:37 AM10/8/24
to django-...@googlegroups.com
#35742: Avoid refering to "username" in admin templates as USERNAME_FIELD can be
updated
-------------------------------------+-------------------------------------
Reporter: antoliny0919 | Owner:
Type: | antoliny0919
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 5.1
Severity: Normal | Resolution:
Keywords: UserAdmin, | Triage Stage: Accepted
USERNAME_FIELD |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35742#comment:27>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 8, 2024, 3:38:22 AM10/8/24
to django-...@googlegroups.com
#35742: Avoid refering to "username" in admin templates as USERNAME_FIELD can be
updated
-------------------------------------+-------------------------------------
Reporter: antoliny0919 | Owner:
Type: | antoliny0919
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 5.1
Severity: Normal | Resolution:
Keywords: UserAdmin, | Triage Stage: Ready for
USERNAME_FIELD | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35742#comment:28>

Django

unread,
Oct 8, 2024, 4:19:01 AM10/8/24
to django-...@googlegroups.com
#35742: Avoid refering to "username" in admin templates as USERNAME_FIELD can be
updated
-------------------------------------+-------------------------------------
Reporter: antoliny0919 | Owner:
Type: | antoliny0919
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: UserAdmin, | Triage Stage: Ready for
USERNAME_FIELD | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"862026a8b93febcf20f91479d07fea0e47118836" 862026a8]:
{{{#!CommitTicketReference repository=""
revision="862026a8b93febcf20f91479d07fea0e47118836"
Fixed #35742 -- Removed hardcoded "username" references in admin
templates.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35742#comment:29>

Django

unread,
Oct 26, 2024, 5:51:33 AM10/26/24
to django-...@googlegroups.com
#35742: Avoid refering to "username" in admin templates as USERNAME_FIELD can be
updated
-------------------------------------+-------------------------------------
Reporter: antoliny0919 | Owner:
Type: | antoliny0919
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: UserAdmin, | Triage Stage: Ready for
USERNAME_FIELD | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):

In [changeset:"43287cbb87bc5e99a2fd384082a719d8b4d253c6" 43287cbb]:
{{{#!CommitTicketReference repository=""
revision="43287cbb87bc5e99a2fd384082a719d8b4d253c6"
Refs #35742 -- Used curly quote in add user form message.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35742#comment:30>
Reply all
Reply to author
Forward
0 new messages