Re: [Django] #35809: Background color for admin's m2m multi-select "selected" rows is lost in dark theme

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme
-------------------------------------+------------------------------------
Reporter: Giannis Terzopoulos | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+------------------------------------
Changes (by Tom Carrick):

* keywords: => accessibility

--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme

-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: Natalia
| Bidart
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* owner: (none) => Natalia Bidart
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:5>

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Sarah Abderemane):

Hi Natalia,
I didn't check the code yet, but this might be an issue with the CSS class
`:focus` on the element if there is one (or missing)
or it could be the change of `::-moz-focus-inner` CSS class if the
property exist in the CSS stylesheet. I can check deeper if needed :)
--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:6>

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:7>

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: Natalia
| Bidart

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"679d57816d716cbc7cff3b364ae265d70444ebd9" 679d578]:
{{{#!CommitTicketReference repository=""
revision="679d57816d716cbc7cff3b364ae265d70444ebd9"
Fixed #35809 -- Set background color for selected rows in the admin's form
select widget.

Regression in b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9.

Thank you Giannis Terzopoulos for the review, and Tom Carrick and Sarah
Boyce
for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:8>

[Django]

#35809: Background color for admin's m2m multi-select "selected" rows is lost in
dark theme
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: Natalia
| Bidart
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"17fa7592af2542d634499c094aa80c4d712948ed" 17fa7592]:
{{{#!CommitTicketReference repository=""
revision="17fa7592af2542d634499c094aa80c4d712948ed"
[5.1.x] Fixed #35809 -- Set background color for selected rows in the

admin's form select widget.

Regression in b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9.

Thank you Giannis Terzopoulos for the review, and Tom Carrick and Sarah
Boyce
for the review.

Backport of 679d57816d716cbc7cff3b364ae265d70444ebd9 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:9>