[Django] #35809: Improved background color for admin's m2m multi-select

12 views
Skip to first unread message

Django

unread,
Oct 3, 2024, 10:57:57 AM10/3/24
to django-...@googlegroups.com
#35809: Improved background color for admin's m2m multi-select
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Type:
| Uncategorized
Status: new | Component:
| Uncategorized
Version: 5.1 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
I noticed today that the color that is currently used for selected m2m
items is indistinguishable. It might not be as noticeable to others, I'm
not sure, I have some color difficulties. Only dark theme seems to be
affected.

I am attaching 2 screenshots, how it looks on 5.1 and on 5.0.9
--
Ticket URL: <https://code.djangoproject.com/ticket/35809>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 3, 2024, 10:58:26 AM10/3/24
to django-...@googlegroups.com
#35809: Improved background color for admin's m2m multi-select
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: (none)
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Giannis Terzopoulos):

* Attachment "django_5.1.png" added.

Django

unread,
Oct 3, 2024, 10:58:27 AM10/3/24
to django-...@googlegroups.com
#35809: Improved background color for admin's m2m multi-select
-------------------------------------+-------------------------------------
Reporter: Giannis Terzopoulos | Owner: (none)
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Giannis Terzopoulos):

* Attachment "django_5.0.9.png" added.

Django

unread,
Oct 3, 2024, 12:49:43 PM10/3/24
to django-...@googlegroups.com
#35809: Improved background color for admin's m2m multi-select
-------------------------------------+------------------------------------
Reporter: Giannis Terzopoulos | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* cc: eroselli (added)
* component: Uncategorized => contrib.admin
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
* type: Uncategorized => Bug
* ui_ux: 0 => 1

Comment:

Hello Giannis, thank you for your report!

I have tried to reproduce and these are my findings:
* in Chrome, both light and dark mode have good contrast for the selected
m2m, both when the m2m widget has focus and when it does not.
* in Firefox, when using the dark theme, there is good contrast for when
the m2m widget has focus but there is no color difference when the focus
is moved to another element.

I bisected the regressing revno to be
b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9

Would you like to prepare a patch?
--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:1>

Django

unread,
Oct 3, 2024, 12:51:08 PM10/3/24
to django-...@googlegroups.com
#35809: Improved background color for admin's m2m multi-select
-------------------------------------+------------------------------------
Reporter: Giannis Terzopoulos | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* cc: eroselli (removed)
* cc: Thibaud Colas, Tom Carrick, Sarah Abderemane, Eliana Rosselli
(added)

Comment:

Added Accessibility team as cc, would you have any recommendation?
--
Ticket URL: <https://code.djangoproject.com/ticket/35809#comment:2>
Reply all
Reply to author
Forward
0 new messages