[Django] #35791: Inline remove buttons are too small

16 views
Skip to first unread message

Django

unread,
Sep 26, 2024, 11:10:27 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Type: Bug
Status: new | Component:
| contrib.admin
Version: 5.0 | Severity: Normal
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
The inline remove button in django admin is too small 16x16 pixels but the
recommended size is 24x24 pixels: 2.5.8 Target Size (Minimum)
https://www.w3.org/WAI/WCAG22/quickref/#target-size-minimum

Using the button at the recommended minimum size would be helpful in
providing a better user experience and provide useful information for all
users.
--
Ticket URL: <https://code.djangoproject.com/ticket/35791>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 26, 2024, 11:16:24 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Screenshot 2024-09-26 at 11.15.45.png" added.

Django

unread,
Sep 26, 2024, 11:16:38 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Screenshot 2024-09-26 at 11.15.45.png" removed.

Django

unread,
Sep 26, 2024, 11:17:10 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS.png" added.

Django

unread,
Sep 26, 2024, 11:18:17 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS.png"
removed.

Django

unread,
Sep 26, 2024, 11:18:26 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS.png" added.

Django

unread,
Sep 26, 2024, 11:18:59 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS resized.png"

Django

unread,
Sep 26, 2024, 11:19:45 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS
resized.2.png" added.

Django

unread,
Sep 26, 2024, 11:20:08 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS
resized.2.png" removed.

Django

unread,
Sep 26, 2024, 11:20:09 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "Inlines delete button sizes screenshot with CSS.png"

Django

unread,
Sep 26, 2024, 11:23:50 AM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
| Nanyonga
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* owner: (none) => Eva Nanyonga
* status: new => assigned

Comment:

Confirmed this is an issue. See
[https://thibaudcolas.github.io/django_admin_tests/v5.1/english/admin/demo/artist/3Rp3pcr8W9rhgF8YhHqplP/change/
demo page] with inlines for releases. The current 16x16 size is
incompatible with [https://www.w3.org/WAI/WCAG22/quickref/#target-size-
minimum 2.5.8 Target Size (Minimum)].

Screenshot:

[[Image(https://code.djangoproject.com/raw-
attachment/ticket/35791/Inlines%20delete%20button%20sizes%20screenshot%20with%20CSS%20resized.png)]]

---

We can make this button the target minimum of 24x24 – likely updating the
CSS, and possibly the SVG image.
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:1>

Django

unread,
Sep 26, 2024, 5:58:29 PM9/26/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
| Nanyonga
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* has_patch: 0 => 1

Comment:

pull request from Eva: [https://github.com/django/django/pull/18624
#18624]
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:2>

Django

unread,
Sep 27, 2024, 2:33:59 AM9/27/24
to django-...@googlegroups.com
#35791: Inline remove buttons are too small
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
Type: | Nanyonga
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* stage: Unreviewed => Accepted
* type: Bug => Cleanup/optimization
* version: 5.0 => dev

Comment:

Thibaud, feel free to accept tickets when you agree with the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:3>
Reply all
Reply to author
Forward
0 new messages