[Django] #35666: Stack level of deprecation warnings should be tested

7 views
Skip to first unread message

Django

unread,
Aug 9, 2024, 1:03:09 PM8/9/24
to django-...@googlegroups.com
#35666: Stack level of deprecation warnings should be tested
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Type:
| Cleanup/optimization
Status: new | Component: Testing
| framework
Version: 5.1 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
With [https://github.com/django/django/pull/18463/ another improperly set]
instance of `stacklevel` and [https://github.com/django/django/pull/17490
few] [https://github.com/django/django/pull/17351 others] behind our belt
I think it's worth documenting and adjusting our test suite to
systematically test against the `assertWarnsMessage.filename` to ensure is
it properly assigned.
--
Ticket URL: <https://code.djangoproject.com/ticket/35666>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 12, 2024, 9:37:34 AM8/12/24
to django-...@googlegroups.com
#35666: Stack level of deprecation warnings should be tested
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* owner: (none) => Simon Charette
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
* status: new => assigned

Comment:

Thank you Simon, I agree with your rationale.

I think some of the commits from your PR should be backported to `5.1` so
I'll be marking this as a release blocker for `5.1`.
--
Ticket URL: <https://code.djangoproject.com/ticket/35666#comment:1>

Django

unread,
Aug 12, 2024, 9:42:59 AM8/12/24
to django-...@googlegroups.com
#35666: Stack level of deprecation warnings should be tested
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/18464 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35666#comment:2>

Django

unread,
Aug 12, 2024, 9:44:11 AM8/12/24
to django-...@googlegroups.com
#35666: Stack level of deprecation warnings should be tested
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):

[https://github.com/django/django/pull/18463/ Related PR from Adam] that
does not show in review queue so I'm adding it here for visibility.
--
Ticket URL: <https://code.djangoproject.com/ticket/35666#comment:3>
Reply all
Reply to author
Forward
0 new messages