Re: [Django] #34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg transforms).

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: orm, json, ordering | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_docs: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: orm, json, ordering | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Charette):

* needs_better_patch: 1 => 0
* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:16>

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: orm, json, ordering | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:17>

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette

Type: New feature | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: orm, json, ordering | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"b0ad41198b3e333f57351e3fce5a1fb47f23f376" b0ad4119]:
{{{
#!CommitTicketReference repository=""
revision="b0ad41198b3e333f57351e3fce5a1fb47f23f376"
Fixed #34013 -- Added QuerySet.order_by() support for annotation
transforms.

Thanks Eugene Morozov and Ben Nace for the reports.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:18>

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: closed
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: orm, json, ordering | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"eea4f92f9aa57d1b25f1c28d11c3b5a6a5841e82" eea4f92f]:
{{{
#!CommitTicketReference repository=""
revision="eea4f92f9aa57d1b25f1c28d11c3b5a6a5841e82"
Refs #34013 -- Registered instance lookups as documented in tests.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:19>

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: closed
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: orm, json, ordering | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):

In [changeset:"a16f13a8661297eda12c4177bb01fa2e5b5ccc56" a16f13a]:
{{{#!CommitTicketReference repository=""
revision="a16f13a8661297eda12c4177bb01fa2e5b5ccc56"
Fixed #35643 -- Fixed a crash when ordering a QuerySet by a reference
containing "__".

Regression in b0ad41198b3e333f57351e3fce5a1fb47f23f376.

Refs #34013. The initial logic did not consider that annotation aliases
can include lookup or transform separators.

Thanks Gert Van Gool for the report and Mariusz Felisiak for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:20>

[Django]

#34013: Support ordering by annotation transforms (e.g JSONObject/ArrayAgg
transforms).
-------------------------------------+-------------------------------------
Reporter: Eugene Morozov | Owner: Simon
| Charette
Type: New feature | Status: closed
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: orm, json, ordering | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"55f529270125e17bf428585734dbcb33332a46de" 55f5292]:
{{{#!CommitTicketReference repository=""
revision="55f529270125e17bf428585734dbcb33332a46de"
[5.1.x] Fixed #35643 -- Fixed a crash when ordering a QuerySet by a

reference containing "__".

Regression in b0ad41198b3e333f57351e3fce5a1fb47f23f376.

Refs #34013. The initial logic did not consider that annotation aliases
can include lookup or transform separators.

Thanks Gert Van Gool for the report and Mariusz Felisiak for the review.

Backport of a16f13a8661297eda12c4177bb01fa2e5b5ccc56 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34013#comment:21>