[Django] #35639: Title of deletion confirmation page could be clearer

25 views
Skip to first unread message

Django

unread,
Jul 29, 2024, 5:37:22 AM7/29/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Type:
| Cleanup/optimization
Status: new | Component:
| contrib.admin
Version: 5.0 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Currently, both the `delete_selected` actions confirmation page and the
page for deleting a single object have the title "Are you sure?"

The "Are you sure" is immediately repeated in the sentence below.

I propose replacing the title with the value from the breadcrumb, "Delete
multiple objects" and "Delete", to make it clearer to users that they are
about to confirm a destructive action.

(This has happened multiple times in the last few years, and has been
reported as a problem by a client, it's not just me bikeshedding here.)
--
Ticket URL: <https://code.djangoproject.com/ticket/35639>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 29, 2024, 5:40:06 AM7/29/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Matthias Kestenholz):

[https://github.com/django/django/pull/18422 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:1>

Django

unread,
Jul 29, 2024, 8:54:35 AM7/29/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
--------------------------------------+------------------------------------
Reporter: Matthias Kestenholz | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted
* version: 5.0 => dev

Comment:

Hello Matthias, thank you for taking the time to create this ticket.

I agree with your rationale! Your PR will be reviewed soon.
--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:2>

Django

unread,
Jul 29, 2024, 10:49:27 AM7/29/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
--------------------------------------+------------------------------------
Reporter: Matthias Kestenholz | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:3>

Django

unread,
Jul 29, 2024, 11:09:13 AM7/29/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Owner: Matthias
Type: | Kestenholz
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Matthias Kestenholz):

* needs_tests: 1 => 0
* owner: (none) => Matthias Kestenholz
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:4>

Django

unread,
Aug 7, 2024, 5:08:57 PM8/7/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Owner: Matthias
Type: | Kestenholz
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:5>

Django

unread,
Aug 7, 2024, 5:10:58 PM8/7/24
to django-...@googlegroups.com
#35639: Title of deletion confirmation page could be clearer
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Owner: Matthias
Type: | Kestenholz
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"54888408a1e5552d9a42584550bda2355ed45943" 54888408]:
{{{#!CommitTicketReference repository=""
revision="54888408a1e5552d9a42584550bda2355ed45943"
Fixed #35639 -- Improved admin's delete confirmation page title.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35639#comment:6>
Reply all
Reply to author
Forward
0 new messages