[Django] #35558: Inline header styling regression

12 views
Skip to first unread message

Django

unread,
Jun 25, 2024, 3:49:20 AM6/25/24
to django-...@googlegroups.com
#35558: Inline header styling regression
-------------------------------------------+-----------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+-----------------------------
Previously inline headers would always be a h4 but since #35189 these can
be a h3.
This update has been done for a correct html structure and should not be
reverted 👍
However we are missing some background colour and border styling that help
visually distinguish these headers when the header is a h3
Screenshots and PR to be added shortly
--
Ticket URL: <https://code.djangoproject.com/ticket/35558>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 25, 2024, 5:24:29 AM6/25/24
to django-...@googlegroups.com
#35558: Inline header styling regression
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20240625-112423.png" added.

Django

unread,
Jun 25, 2024, 5:26:18 AM6/25/24
to django-...@googlegroups.com
#35558: Inline header styling regression
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20240625-112612.png" added.

Django

unread,
Jun 25, 2024, 5:29:52 AM6/25/24
to django-...@googlegroups.com
#35558: Inline header styling regression
---------------------------------+---------------------------------------
Reporter: Sarah Boyce | Owner: Sarah Boyce
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Sarah Boyce):

* has_patch: 0 => 1


Old description:

> Previously inline headers would always be a h4 but since #35189 these can
> be a h3.
> This update has been done for a correct html structure and should not be
> reverted 👍
> However we are missing some background colour and border styling that
> help visually distinguish these headers when the header is a h3
> Screenshots and PR to be added shortly

New description:

Previously inline headers would always be a h4 but since #35189 these can
be a h3.
This update has been done for a correct html structure and should not be
reverted 👍

However the header has become less visually distinguishable from the
content.

Now:
[[Image(image-20240625-112423.png​)]]

Previously (picture from docs):
[[Image(image-20240625-112612.png​)]]

--
--
Ticket URL: <https://code.djangoproject.com/ticket/35558#comment:1>
Reply all
Reply to author
Forward
0 new messages