[Django] #35540: Admin login form padding issue

[Django]

#35540: Admin login form padding issue
-----------------------------------------+------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
If you look at the tutorial with an older screenshot of the Django admin,
we're expecting some padding below the login button:
https://docs.djangoproject.com/en/5.0/intro/tutorial02/#start-the-
development-server


Suggested update:
{{{#!diff
diff --git a/django/contrib/admin/static/admin/css/login.css
b/django/contrib/admin/static/admin/css/login.css
index 389772f5bc..805a34b5bd 100644
--- a/django/contrib/admin/static/admin/css/login.css
+++ b/django/contrib/admin/static/admin/css/login.css
@@ -21,7 +21,7 @@
}

.login #content {
- padding: 20px 20px 0;
+ padding: 20px;
}

.login #container {
}}}


Whoever picks this up should also update the image
`docs/intro/_images/admin01.png` so that it has the latest styles 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35540>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35540: Admin login form padding issue

-------------------------------+--------------------------------------

Reporter: Sarah Boyce | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20240620-130503.png" added.

[Django]

#35540: Admin login form padding issue
-------------------------------+--------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* Attachment "image-20240620-130526.png" added.

[Django]

#35540: Admin login form padding issue
-------------------------------+--------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Description changed by Sarah Boyce:

Old description:

> If you look at the tutorial with an older screenshot of the Django admin,
> we're expecting some padding below the login button:
> https://docs.djangoproject.com/en/5.0/intro/tutorial02/#start-the-
> development-server
>

> Suggested update:
> {{{#!diff
> diff --git a/django/contrib/admin/static/admin/css/login.css
> b/django/contrib/admin/static/admin/css/login.css
> index 389772f5bc..805a34b5bd 100644
> --- a/django/contrib/admin/static/admin/css/login.css
> +++ b/django/contrib/admin/static/admin/css/login.css
> @@ -21,7 +21,7 @@
> }
>
> .login #content {
> - padding: 20px 20px 0;
> + padding: 20px;
> }
>
> .login #container {
> }}}
>

> Whoever picks this up should also update the image
> `docs/intro/_images/admin01.png` so that it has the latest styles 👍

New description:

If you look at the tutorial with an older screenshot of the Django admin,
we're expecting some padding below the login button:
https://docs.djangoproject.com/en/5.0/intro/tutorial02/#start-the-
development-server

Current

[[Image(image-20240620-130503.png)]]

Suggested update:
{{{#!diff
diff --git a/django/contrib/admin/static/admin/css/login.css
b/django/contrib/admin/static/admin/css/login.css
index 389772f5bc..805a34b5bd 100644
--- a/django/contrib/admin/static/admin/css/login.css
+++ b/django/contrib/admin/static/admin/css/login.css
@@ -21,7 +21,7 @@
}

.login #content {
- padding: 20px 20px 0;
+ padding: 20px;
}

.login #container {
}}}

After

[[Image(image-20240620-130526.png)]]

Whoever picks this up should also update the image
`docs/intro/_images/admin01.png` so that it has the latest styles 👍

--

--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:1>

[Django]

#35540: Admin login form padding issue

-------------------------------+-----------------------------------------
Reporter: Sarah Boyce | Owner: Anthony Kugel
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+-----------------------------------------
Changes (by Anthony Kugel):

* owner: nobody => Anthony Kugel
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:2>

[Django]

#35540: Admin login form padding issue
-------------------------------+-----------------------------------------
Reporter: Sarah Boyce | Owner: Anthony Kugel
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------+-----------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted
* ui_ux: 0 => 1

Comment:

Another great catch, thank you Sarah! Confirmed that 5.0 is not affected.
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:3>

[Django]

#35540: Admin login form padding issue
-------------------------------+-----------------------------------------
Reporter: Sarah Boyce | Owner: Anthony Kugel
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+-----------------------------------------

Comment (by arjun omray):

Hey, can I work on this issue if it is available?
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:4>

[Django]

#35540: Admin login form padding issue

---------------------------------+-----------------------------------------

Reporter: Sarah Boyce | Owner: Anthony Kugel
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1

Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

---------------------------------+-----------------------------------------
Changes (by Sarah Boyce):

* severity: Normal => Release blocker

Comment:

As 5.0 is not affected, marking as a release blocker for 5.1

Replying to [comment:4 arjun omray]:

> Hey, can I work on this issue if it is available?

I see Anthony assigned themselves recently but hasn't raised a PR. As we
will need an update here relatively soon, I would say yes you can work on
it.
Normally I would say we should wait a bit longer but release blockers are
special cases
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:5>

[Django]

#35540: Admin login form padding issue
---------------------------------+---------------------------------------

Reporter: Sarah Boyce | Owner: arjun omray

Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------

Changes (by arjun omray):

* has_patch: 0 => 1
* owner: Anthony Kugel => arjun omray

Comment:

[https://github.com/django/django/pull/18306]

Okay, I have raised a PR for this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:6>

[Django]

#35540: Admin login form padding issue

-------------------------------------+-------------------------------------

Reporter: Sarah Boyce | Owner: arjun
| omray
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:7>

[Django]

#35540: Admin login form padding issue
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: arjun
| omray

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"d9bd58c3b8b3e8735d8242c2bb9b09c52ed6171b" d9bd58c]:
{{{#!CommitTicketReference repository=""
revision="d9bd58c3b8b3e8735d8242c2bb9b09c52ed6171b"
Fixed #35540 -- Fixed the padding on admin login page.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:8>

[Django]

#35540: Admin login form padding issue
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: arjun
| omray
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"ddf81f023fd875fb318138ac7cb279fbdeee5f8b" ddf81f0]:
{{{#!CommitTicketReference repository=""
revision="ddf81f023fd875fb318138ac7cb279fbdeee5f8b"
[5.1.x] Fixed #35540 -- Fixed the padding on admin login page.

Backport of d9bd58c3b8b3e8735d8242c2bb9b09c52ed6171b from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35540#comment:9>