[Django] #35533: urlize() makes a bit of a mess of links embedded in Markdown

74 views
Skip to first unread message

Django

unread,
Jun 18, 2024, 1:15:08 PM6/18/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
------------------------------------------+------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
I have this input text:

{{{
Annotated versions of talks I have given, with extensive notes and
additional links. Here's [how I make
these](https://simonwillison.net/2023/Aug/6/annotated-presentations/).
}}}

After running through Django's urlize helper function I got this:
{{{
... Here&#x27;s [how I make <a
href="http://these](https://simonwillison.net/2023/Aug/6/annotated-
presentations/)"
rel="nofollow">these](https://simonwillison.net/2023/Aug/6/annotated-
presentations/)</a>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35533>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 18, 2024, 1:19:28 PM6/18/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Comment (by Simon Willison):

The ideal output for this example would be:
{{{
Annotated versions of talks I have given, with extensive notes and
additional links. Here's [how I make these](<a
href="https://simonwillison.net/2023/Aug/6/annotated-presentations/"
rel="nofollow">https://simonwillison.net/2023/Aug/6/annotated-
presentations/</a>).
}}}
Alternatively, not URLizing at all would be preferable to URLizing in a
way that produces broken links.

I think what's happening here is the logic that looks for non-protocol
links that include or end in .net may be kicking in, and deciding that the
following is the URL that should be linked:
{{{
these](https://simonwillison.net/2023/Aug/6/annotated-presentations/)
}}}
It's hard to suggest a fix for this. Ideally the code would "notice" that
`these](https://simonwillison.net/2023` is not a valid URL, but instead
the logic is deciding that it's probably valid but should have `http://`
glued on the start.

Maybe we could have code that notices that
`http://these](https://simonwillison.net/2023/Aug/6/annotated-
presentations/)` is NOT a valid URL - you cannot have `](` in the middle
of the hostname portion - and hence decides not to URLize it at all.

(Background: the reason I'm seeing this is that my Django SQL Dashboard
software tries to URLize text it displays, but has no way of knowing if a
database column contains Markdown - this broken example came from
https://simonwillison.net/dashboard/tags-with-descriptions/ )
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:1>

Django

unread,
Jun 18, 2024, 1:20:41 PM6/18/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by Simon Willison):

* Attachment "screenshot-of-markdown.jpg" added.

Django

unread,
Jun 18, 2024, 1:22:16 PM6/18/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Comment (by Simon Willison):

Current URLizer code is here:
https://github.com/django/django/blob/2719a7f8c161233f45d34b624a9df9392c86cc1b/django/utils/html.py#L258-L413
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:2>

Django

unread,
Jun 19, 2024, 3:17:59 AM6/19/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+------------------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

Comment:

Thank you for the report! Replicated 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:3>

Django

unread,
Jun 19, 2024, 3:19:00 AM6/19/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+------------------------------------
Reporter: Simon Willison | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Changes (by Sarah Boyce):

* cc: Adam Johnson (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:4>

Django

unread,
Jun 21, 2024, 2:46:40 PM6/21/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* owner: nobody => DongwookKim0823
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:5>

Django

unread,
Jun 23, 2024, 12:37:50 AM6/23/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Vaarun Sinha):

Hey DongwookKim0823? Are you actively working on this? Do you require any
help? Would love to help
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:6>

Django

unread,
Jun 23, 2024, 1:32:03 AM6/23/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by DongwookKim0823):

Replying to [comment:6 Vaarun Sinha]:

I'm currently working on this. I'll leave a comment if I need any help.
Thank you! :)
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:7>

Django

unread,
Jun 24, 2024, 1:59:09 AM6/24/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:8>

Django

unread,
Jun 24, 2024, 2:08:39 AM6/24/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "0001-Fixed-35533-Improved-urlize-function-to-handle-
markd.patch" added.

Django

unread,
Jun 24, 2024, 3:46:33 AM6/24/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "0001-Fixed-markdown-hyperlink-handling-in-urlize-
function.patch" added.

Django

unread,
Jun 25, 2024, 9:42:04 AM6/25/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "0001-Fixed-35533-Improved-urlize-function-to-handle-
markd.patch" removed.

Django

unread,
Jun 25, 2024, 9:42:07 AM6/25/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "0001-Fixed-markdown-hyperlink-handling-in-urlize-
function.patch" removed.

Django

unread,
Jun 25, 2024, 9:48:26 AM6/25/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 28, 2024, 5:16:52 AM6/28/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:9>

Django

unread,
Jun 29, 2024, 5:49:55 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 7:23:46 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 7:24:30 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 7:26:36 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 7:28:07 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 7:31:16 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 7:31:26 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 7:32:49 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 7:33:05 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 7:43:35 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 7:44:17 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:01:55 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:04:31 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:05:24 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:15:51 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:17:00 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:17:58 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:22:07 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:22:27 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:24:51 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:25:31 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 8:26:51 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jun 29, 2024, 8:27:02 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" removed.

Django

unread,
Jun 29, 2024, 10:04:39 AM6/29/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by DongwookKim0823):

* Attachment "changes.patch" added.

Django

unread,
Jul 11, 2024, 1:37:58 PM7/11/24
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| DongwookKim0823
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by DongwookKim0823):

Replying to [comment:6 Vaarun Sinha]:

I made some progress on this issue, but I think collaborating on a better
solution would be great. I’d love to work together and find the best
approach.
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:10>

Django

unread,
Aug 26, 2025, 12:38:04 PMAug 26
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by JaeHyuckSa):

* needs_better_patch: 1 => 0
* owner: DongwookKim0823 => JaeHyuckSa

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:11>

Django

unread,
Aug 27, 2025, 5:52:50 AMAug 27
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:12>

Django

unread,
Aug 27, 2025, 10:28:35 AMAug 27
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
--------------------------------+--------------------------------------
Reporter: Simon Willison | Owner: JaeHyuckSa
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by JaeHyuckSa):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:13>

Django

unread,
Aug 27, 2025, 11:05:12 AMAug 27
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| JaeHyuckSa
Type: Bug | Status: assigned
Component: Utilities | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:14>

Django

unread,
Aug 28, 2025, 2:55:06 AMAug 28
to django-...@googlegroups.com
#35533: urlize() makes a bit of a mess of links embedded in Markdown
-------------------------------------+-------------------------------------
Reporter: Simon Willison | Owner:
| JaeHyuckSa
Type: Bug | Status: closed
Component: Utilities | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"a9fe98d5bd4212d069afe8316101984aadecfbb2" a9fe98d5]:
{{{#!CommitTicketReference repository=""
revision="a9fe98d5bd4212d069afe8316101984aadecfbb2"
Fixed #35533 -- Prevented urlize creating broken links given a markdown
link input.

Signed-off-by: SaJH <wogur...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35533#comment:15>
Reply all
Reply to author
Forward
0 new messages