Re: [Django] #35443: Fix negative numbers for ordinals

11 views
Skip to first unread message

Django

unread,
May 16, 2024, 4:21:34 AM5/16/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 5.0
Severity: Normal | Resolution:
Keywords: humanize ordinal | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Crustum7):

* owner: nobody => S-Tornqvist, Crustum7
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 16, 2024, 4:31:07 AM5/16/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 5.0
Severity: Normal | Resolution:
Keywords: humanize ordinal | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Crustum7):

* cc: Crustum7 (added)
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:3>

Django

unread,
May 22, 2024, 6:15:36 AM5/22/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 5.0
Severity: Normal | Resolution:
Keywords: humanize ordinal | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:4>

Django

unread,
May 27, 2024, 4:07:39 AM5/27/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: assigned
Component: contrib.humanize | Version: dev
Severity: Normal | Resolution:
Keywords: humanize ordinal | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
* version: 5.0 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:5>

Django

unread,
May 27, 2024, 4:54:36 AM5/27/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: closed
Component: contrib.humanize | Version: dev
Severity: Normal | Resolution: fixed
Keywords: humanize ordinal | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"d3a7ed5bcc45000a6c3dd55d85a4caaa83299f83" d3a7ed5b]:
{{{#!CommitTicketReference repository=""
revision="d3a7ed5bcc45000a6c3dd55d85a4caaa83299f83"
Fixed #35443 -- Changed ordinal to return negative numbers unchanged.

Previously, `-1` was converted to `"-1th"`. This has been updated to
return negative numbers "as is", so that for example `-1` is
converted to `"-1"`. This is now explicit in the docs.

Co-authored-by: Martin Jonson <artin...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:6>

Django

unread,
Jun 14, 2024, 8:22:33 AM6/14/24
to django-...@googlegroups.com
#35443: Fix negative numbers for ordinals
-------------------------------------+-------------------------------------
Reporter: Siburg | Owner:
| S-Tornqvist, Crustum7
Type: Bug | Status: closed
Component: contrib.humanize | Version: dev
Severity: Normal | Resolution: fixed
Keywords: humanize ordinal | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"e65b7d5b069a815a9a07f48219cd6bb9a4a663c1" e65b7d5]:
{{{#!CommitTicketReference repository=""
revision="e65b7d5b069a815a9a07f48219cd6bb9a4a663c1"
[5.1.x] Fixed #35443 -- Changed ordinal to return negative numbers
unchanged.

Previously, `-1` was converted to `"-1th"`. This has been updated to
return negative numbers "as is", so that for example `-1` is
converted to `"-1"`. This is now explicit in the docs.

Co-authored-by: Martin Jonson <artin...@gmail.com>

Backport of d3a7ed5bcc45000a6c3dd55d85a4caaa83299f83 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35443#comment:7>
Reply all
Reply to author
Forward
0 new messages