[Django] #35472: Image files aren't cleaned up after running tests

19 views
Skip to first unread message

Django

unread,
May 22, 2024, 9:39:02 AM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
------------------------------------------------+------------------------
Reporter: bcail | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
After each run of the django test suite, I'm seeing two image files
("mug*") left on the filesystem. It looks like the issue is from this
commit: 9c5fe93349bd4339c41d057b87046e5d28be6f77.
--
Ticket URL: <https://code.djangoproject.com/ticket/35472>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 22, 2024, 1:34:37 PM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
--------------------------------------+------------------------------------
Reporter: bcail | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: File uploads/storage | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Sarah Boyce):

* component: Uncategorized => File uploads/storage
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
* version: dev => 5.1

Comment:

Thank you bcail!
Yes, this was introduced in 9c5fe93349bd4339c41d057b87046e5d28be6f77
(#35139), I have raised a patch. I think we should backport this into 5.1
👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35472#comment:1>

Django

unread,
May 22, 2024, 3:12:52 PM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
--------------------------------------+------------------------------------
Reporter: bcail | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: File uploads/storage | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* severity: Normal => Release blocker

Comment:

Marking as release blocker so we backport to `stable/5.1.x`.
--
Ticket URL: <https://code.djangoproject.com/ticket/35472#comment:2>

Django

unread,
May 22, 2024, 3:37:33 PM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
--------------------------------------+------------------------------------
Reporter: bcail | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: File uploads/storage | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: new => closed

Comment:

In [changeset:"7e39ae5c8cf4c6601a4f47b72914349481c5331b" 7e39ae5]:
{{{#!CommitTicketReference repository=""
revision="7e39ae5c8cf4c6601a4f47b72914349481c5331b"
Fixed #35472 -- Used temporary directory in test_imagefield.NoReadTests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35472#comment:3>

Django

unread,
May 22, 2024, 3:38:52 PM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
--------------------------------------+------------------------------------
Reporter: bcail | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: File uploads/storage | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"501e32a7f5012aa014931a39699391d91ca0a9be" 501e32a]:
{{{#!CommitTicketReference repository=""
revision="501e32a7f5012aa014931a39699391d91ca0a9be"
[5.1.x] Fixed #35472 -- Used temporary directory in
test_imagefield.NoReadTests.

Backport of 7e39ae5c8cf4c6601a4f47b72914349481c5331b from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35472#comment:4>

Django

unread,
May 22, 2024, 3:39:18 PM5/22/24
to django-...@googlegroups.com
#35472: Image files aren't cleaned up after running tests
-------------------------------------+-------------------------------------
Reporter: bcail | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: File | Version: 5.1
uploads/storage |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35472#comment:5>
Reply all
Reply to author
Forward
0 new messages