Re: [Django] #34917: Links in the Django admin should be underlined.

Django

unread,

Feb 8, 2024, 3:09:55 PM2/8/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
anchor | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Tom Carrick):

So we've had a brief discussion and we've agreed that links in the "main
content area" should be underlined.

My personal thought on "main content area" is "not the header or nav
sidebar".

I think this should ideally exclude the site index and app index pages
(they're quite clear), but acceptable if these are underlined as well.

There will probably also be other exceptions such as pagination links and
other links that look like buttons, but I think we can tease those out in
a review.
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Feb 15, 2024, 10:45:22 AM2/15/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Accepted
anchor |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Tom Carrick):

* has_patch: 0 => 1
* needs_better_patch: 0 => 1
* stage: Someday/Maybe => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:10>

Django

unread,

Feb 21, 2024, 9:41:29 AM2/21/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
anchor |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Maira Usman):

I have opened pull request : [https://github.com/django/django/pull/17883]
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:11>

Django

unread,

Feb 21, 2024, 11:24:09 AM2/21/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
anchor |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Emmanuel Maunga):

What do I do now that I am interested in working on this ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:12>

Django

unread,

Mar 12, 2024, 1:57:10 AM3/12/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
anchor |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Ülgen Sarıkavak):

* cc: Ülgen Sarıkavak (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:13>

Django

unread,

Apr 12, 2024, 8:50:20 PM4/12/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------

Reporter: Dmitriy Chukhin | Owner: avish
Type: | mehta
Cleanup/optimization | Status: assigned

Changes (by avish mehta):

* owner: nobody => avish mehta
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:14>

Django

unread,

Apr 12, 2024, 8:54:49 PM4/12/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------

Reporter: Dmitriy Chukhin | Owner: (none)
Type: | Status: new
Cleanup/optimization |

* owner: avish mehta => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:15>

Django

unread,

Apr 12, 2024, 9:03:47 PM4/12/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------

Reporter: Dmitriy Chukhin | Owner: nobody

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 1 => 0

Comment:

I believe the [https://github.com/django/django/pull/17883 PR] is awaiting
review.
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:14>

Django

unread,

May 5, 2024, 1:47:24 PM5/5/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:15>

Django

unread,

May 5, 2024, 1:55:00 PM5/5/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------

Reporter: Dmitriy Chukhin | Owner: Maira
Type: | Usman
Cleanup/optimization | Status: assigned

* owner: nobody => Maira Usman

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:16>

Django

unread,

Oct 31, 2024, 12:56:28 AM10/31/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: Maira
Type: | Usman
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
anchor |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Alexander Lazarević):

Maira or anybode else has planned to continue working on it?
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:17>

Django

unread,

Dec 16, 2024, 4:55:56 PM12/16/24

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------

Reporter: Dmitriy Chukhin | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |

Changes (by Antoliny):

* owner: Maira Usman => Antoliny

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:18>

Django

unread,

Dec 22, 2024, 3:26:10 PM12/22/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

Comment:

[https://github.com/django/django/pull/18958 new PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:19>

Django

unread,

Jan 22, 2025, 11:42:51 AMJan 22

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:20>

Django

unread,

Jan 23, 2025, 4:40:57 AMJan 23

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:21>

Django

unread,

Jan 30, 2025, 12:19:21 PMJan 30

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:22>

Django

unread,

Jan 30, 2025, 11:03:02 PMJan 30

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:23>

Django

unread,

Mar 25, 2025, 7:00:05 AMMar 25

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:24>

Django

unread,

Mar 25, 2025, 8:45:01 AMMar 25

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:25>

Django

unread,

Mar 25, 2025, 11:02:31 AMMar 25

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:26>

Django

unread,

Mar 25, 2025, 7:18:45 PMMar 25

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:27>

Django

unread,

Mar 26, 2025, 7:02:09 AMMar 26

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Ready for
anchor | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:28>

Django

unread,

Mar 27, 2025, 8:27:47 AMMar 27

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: Antoliny

Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: dev

Severity: Normal | Resolution: fixed

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"849f8307a5bb33465252d0891a9b2c47dde65889" 849f830]:
{{{#!CommitTicketReference repository=""
revision="849f8307a5bb33465252d0891a9b2c47dde65889"
Fixed #34917 -- Underlined links in the main content area of the admin.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:29>

Django

unread,

Jul 30, 2025, 9:37:08 AMJul 30

to django-...@googlegroups.com

#34917: Links in the Django admin should be underlined.
-------------------------------------+-------------------------------------
Reporter: Dmitriy Chukhin | Owner: Antoliny
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
anchor | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"792ca148a2d6da6cf0778f6a866c899208ab94f9" 792ca148]:
{{{#!CommitTicketReference repository=""
revision="792ca148a2d6da6cf0778f6a866c899208ab94f9"
Fixed #36528, Refs #34917 -- Removed role="button" from object-tools
links.

Regression in 849f8307a5bb33465252d0891a9b2c47dde65889.
In order to prevent underlines on links styled like buttons, role="button"
was added.
This has been removed and the style updated to reflect that these are
links.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34917#comment:30>

Reply all

Reply to author

Forward