Re: [Django] #12978: Support in syndication framework for CSS stylesheet links

22 views
Skip to first unread message

Django

unread,
Sep 2, 2011, 11:38:47 AM9/2/11
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: | Owner: yuval_a
intrepidweb | Status: closed
Type: New | Component: contrib.syndication
feature | Severity: Normal
Milestone: 1.4 | Keywords: syndication css
Version: 1.1 | stylesheets
Resolution: fixed | Has patch: 1
Triage Stage: Ready for | Needs tests: 0
checkin | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by yuval_a):

* status: new => closed
* easy: => 0
* milestone: 1.3 => 1.4
* ui_ux: => 0
* resolution: => fixed
* stage: Someday/Maybe => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 2, 2011, 5:01:01 PM9/2/11
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: | Owner: yuval_a
intrepidweb | Status: reopened
Type: New | Component: contrib.syndication
feature | Severity: Normal
Milestone: 1.4 | Keywords: syndication css
Version: 1.1 | stylesheets
Resolution: | Has patch: 1
Triage Stage: | Needs tests: 0
Someday/Maybe | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* status: closed => reopened
* resolution: fixed =>
* stage: Ready for checkin => Someday/Maybe


Comment:

Revert apparent triage error.

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:12>

Django

unread,
Dec 16, 2012, 12:18:02 PM12/16/12
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: yuval_a
Type: New feature | Status: reopened
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* stage: Someday/Maybe => Accepted


Comment:

Accepting based on comment 2.

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:14>

Django

unread,
Jul 30, 2013, 12:10:14 PM7/30/13
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: yuval_a
Type: New feature | Status: new

Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by timo):

Updated the patch to apply cleanly, but noticed with the current
implementation the stylesheets are only added to RSS feeds and not ATOM
feeds. Does ATOM not support stylesheets?

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:16>

Django

unread,
Aug 1, 2014, 6:09:37 PM8/1/14
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: yuval_a
Type: New feature | Status: new
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by CollinAnderson):

Is this still useful now that browsers have dropped the RSS button?

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:17>

Django

unread,
Aug 14, 2014, 10:16:43 AM8/14/14
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: yuval_a
Type: New feature | Status: new
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

I think it's still relevant. feedburner styles their feeds for example. I
updated the patch to apply cleanly again, but we do need to add support
for stylesheets in the ATOM feedgenerator (I started this, but didn't make
the test updates). Also, I think we should avoid hardcoding text/css since
stylesheets could also be xsl. Maybe extracting the stylesheet extension
is enough or maybe the `stylehseets` attribute should be tuples of
`('stylesheet', 'type')`. Finally, the patch is also missing release
notes.

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:18>

Django

unread,
May 2, 2024, 5:38:07 AMMay 2
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Yuval
| Adam
Type: New feature | Status: new
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce):

#35420 possible duplicate, with patch:
https://github.com/django/django/pull/18120
--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:19>

Django

unread,
May 3, 2024, 3:23:36 PMMay 3
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):

* needs_better_patch: 1 => 0
* owner: Yuval Adam => Baptiste Mispelon
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:20>

Django

unread,
May 6, 2024, 5:15:34 AMMay 6
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

Comment:

Patch is missing support for CSS stylesheets 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:21>

Django

unread,
May 7, 2024, 6:26:54 PMMay 7
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):

* easy: => 0
* needs_better_patch: 1 => 0
* ui_ux: => 0

Comment:

I've added support for CSS stylesheets as well and updated the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:22>

Django

unread,
May 15, 2024, 6:22:14 AMMay 15
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

Comment:

Tested using the test project provided by Baptiste and is working well:
https://github.com/bmispelon/django-ticket-35420
Have minor comments on the PR but the main change is requesting support
can adding multiple stylesheets (then some doc updates around that).
I think this is close 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:23>

Django

unread,
May 15, 2024, 9:15:19 AMMay 15
to django-...@googlegroups.com
#12978: Support in syndication framework for CSS stylesheet links
-------------------------------------+-------------------------------------
Reporter: intrepidweb | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 1.1
Severity: Normal | Resolution:
Keywords: syndication css | Triage Stage: Accepted
stylesheets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):

* needs_better_patch: 1 => 0

Comment:

I've pushed an update with support for both single and multiple
stylesheets. I think this is shaping up nicely, I'm enjoying the review
process!
--
Ticket URL: <https://code.djangoproject.com/ticket/12978#comment:24>
Reply all
Reply to author
Forward
0 new messages