Re: [Django] #35422: Migration crash when renaming a field referenced in GeneratedField.expression

9 views
Skip to first unread message

Django

unread,
May 2, 2024, 2:13:37 PMMay 2
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 2, 2024, 2:43:18 PMMay 2
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/18122 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:6>

Django

unread,
May 3, 2024, 2:20:27 AMMay 3
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:7>

Django

unread,
May 3, 2024, 3:28:35 AMMay 3
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"91a4b9a8ec2237434f06866f39c7977e889aeae6" 91a4b9a8]:
{{{#!CommitTicketReference repository=""
revision="91a4b9a8ec2237434f06866f39c7977e889aeae6"
Fixed #35422 -- Fixed migrations crash when altering GeneratedField
referencing rename field.

Thanks Sarah Boyce for the report and Simon Charette for the
implementation idea.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:8>

Django

unread,
May 3, 2024, 3:34:06 AMMay 3
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"c544f1a2237fd18a1e00fef8cbcd1cf7eccd5eb9" c544f1a]:
{{{#!CommitTicketReference repository=""
revision="c544f1a2237fd18a1e00fef8cbcd1cf7eccd5eb9"
[5.0.x] Fixed #35422 -- Fixed migrations crash when altering
GeneratedField referencing rename field.

Thanks Sarah Boyce for the report and Simon Charette for the
implementation idea.

Backport of 91a4b9a8ec2237434f06866f39c7977e889aeae6 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:9>

Django

unread,
May 3, 2024, 12:07:22 PMMay 3
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by nessita <124304+nessita@…>):

In [changeset:"e72049aa6302411d8cdf2e798e15fa38e76b92fc" e72049aa]:
{{{#!CommitTicketReference repository=""
revision="e72049aa6302411d8cdf2e798e15fa38e76b92fc"
Refs #35422 -- Fixed typo in docs/releases/5.0.5.txt.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:10>

Django

unread,
May 3, 2024, 12:20:12 PMMay 3
to django-...@googlegroups.com
#35422: Migration crash when renaming a field referenced in
GeneratedField.expression
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Migrations | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):

In [changeset:"e18e9315a3e8b295cf3763b07cc3b4c3beffca32" e18e931]:
{{{#!CommitTicketReference repository=""
revision="e18e9315a3e8b295cf3763b07cc3b4c3beffca32"
[5.0.x] Refs #35422 -- Fixed typo in docs/releases/5.0.5.txt.

Backport of e72049aa6302411d8cdf2e798e15fa38e76b92fc from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35422#comment:11>
Reply all
Reply to author
Forward
0 new messages