Re: [Django] #35382: Remove unused CSS style `.inline-related fieldset.module h3`

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* keywords: accessibility =>
* type: Bug => Cleanup/optimization

--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172435.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/35382>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172446.png" added.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172534.png" added.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172702.png" added.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172702.png" removed.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172534.png" removed.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172446.png" removed.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* Attachment "image-20240419-172435.png" removed.

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by vinayaka314):

I'm new here and I wanna help. Can anyone guide me, please?
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:7>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Marijke Luttekes):

Hello, author of the fix for the aforementioned other ticket here.

The light blue color used for inline H3s feels random; it does not fit the
Django Admin's color scheme.

Since the CSS hasn't been touched for years and is unused, and the color
is not referred to with CSS custom properties, I assume it's an old
remnant that wasn't meant to match modern admin styles.

Hence I propose we find a style or color that better fits with the current
base colors tint-wise, and find a suitable text color with a WCAG-approved
contrasting text color.

I am not a designer, so I would experiment with my PR and see what works.
It's not a scientific method. If anyone has had a good thought about this
before, let me know!
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:8>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Natalia Bidart):

Just an FYI, this ticket has bee repurposed to fully remove the unused CSS
rule so there is no need to pick new colors. If a new color is needed in a
future work that introduces this h3 back, the colors should be discussed
in that PR/ticket. Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:9>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Marijke Luttekes):

I have removed this whole selector and contents for `.inline-related
fieldset.module h3` in my PR for
[[https://code.djangoproject.com/ticket/35189|ticket #35189]]
([[https://github.com/django/django/pull/17910|PR #17910]]).

Do you want to have this as a separate PR, as well?
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:10>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Sarah Boyce):

> Do you want to have this as a separate PR, as well?

Yes please, let's get this merged as a distinct and independent cleanup
change. Having a ticket to track this is probably overkill, but merging in
a separate commit has a couple of advantages and it's quite common we try
to pull out commits and merge early when possible/appropriate. 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:11>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------

Reporter: Sarah Boyce | Owner: Saurabh
Type: Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Saurabh ):

* owner: nobody => Saurabh
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:12>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: Saurabh
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Sarah Boyce):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:13>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`

-------------------------------------+-------------------------------------

Reporter: Sarah Boyce | Owner: Saurabh

Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:14>

[Django]

#35382: Remove unused CSS style `.inline-related fieldset.module h3`
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Saurabh

Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: 5.0

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"16d0542bb6812b94895136d26f86b33d20e6a072" 16d0542b]:
{{{#!CommitTicketReference repository=""
revision="16d0542bb6812b94895136d26f86b33d20e6a072"
Fixed #35382 -- Removed unused CSS for admin inline fieldsets.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35382#comment:15>