Re: [Django] #35320: Remove unnecessary django.core.files.move._samefile() hook.

[Django]

#35320: Remove unnecessary django.core.files.move._samefile() hook.
--------------------------------------+------------------------------------
Reporter: bcail | Owner: bcail
Type: Cleanup/optimization | Status: assigned
Component: File uploads/storage | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* needs_better_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/18000 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35320#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35320: Remove unnecessary django.core.files.move._samefile() hook.
--------------------------------------+------------------------------------
Reporter: bcail | Owner: bcail
Type: Cleanup/optimization | Status: assigned
Component: File uploads/storage | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by bcail):

* needs_better_patch: 1 => 0

Comment:

Thanks, I changed it to OSError.
--
Ticket URL: <https://code.djangoproject.com/ticket/35320#comment:6>

[Django]

#35320: Remove unnecessary django.core.files.move._samefile() hook.

-------------------------------------+-------------------------------------
Reporter: bcail | Owner: bcail
Type: | Status: assigned
Cleanup/optimization |
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35320#comment:7>

[Django]

#35320: Remove unnecessary django.core.files.move._samefile() hook.
-------------------------------------+-------------------------------------
Reporter: bcail | Owner: bcail

Type: | Status: closed

Cleanup/optimization |
Component: File | Version: dev
uploads/storage |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"8dbfef469582128c9d8487bf3f45d861b2ecfcb9" 8dbfef4]:
{{{#!CommitTicketReference repository=""
revision="8dbfef469582128c9d8487bf3f45d861b2ecfcb9"
Fixed #35320 -- Removed unnecessary django.core.files.move._samefile()
hook.

os.path.samefile() uses the same implementation on Windows as all other
platforms since Python 3.4.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35320#comment:8>