[Django] #35292: Restore autofocus functionality to admin search box within popup interface

6 views
Skip to first unread message

Django

unread,
Mar 12, 2024, 5:34:03 AM3/12/24
to django-...@googlegroups.com
#35292: Restore autofocus functionality to admin search box within popup interface
-------------------------------------+-------------------------------------
Reporter: mulmat | Owner: nobody
Type: | Status: new
Uncategorized |
Component: | Version: 5.0
contrib.admin | Keywords: accessibility,
Severity: Normal | screen reader, keyboard
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
After recently upgrading to Django 4, we've had users report issues
related to the changes made in #34040. The users perform quite a lot of
these searches, and an extra click to focus the search box annoys them. I
wonder if it would be possible to restore the autofocus functionality when
in popup? In the popup context, I think it makes sense to autofocus the
search box.
--
Ticket URL: <https://code.djangoproject.com/ticket/35292>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 12, 2024, 5:45:28 AM3/12/24
to django-...@googlegroups.com
#35292: Restore autofocus functionality to admin search box within popup interface
-------------------------------------+-------------------------------------
Reporter: Mattias L | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, keyboard | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mattias L):

PR up here: https://github.com/django/django/pull/17967
--
Ticket URL: <https://code.djangoproject.com/ticket/35292#comment:1>

Django

unread,
Mar 12, 2024, 5:50:37 AM3/12/24
to django-...@googlegroups.com
#35292: Restore autofocus functionality to admin search box within popup interface
-------------------------------------+-------------------------------------
Reporter: mulmat | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, keyboard | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by mulmat:

Old description:

> After recently upgrading to Django 4, we've had users report issues
> related to the changes made in #34040. The users perform quite a lot of
> these searches, and an extra click to focus the search box annoys them. I
> wonder if it would be possible to restore the autofocus functionality
> when in popup? In the popup context, I think it makes sense to autofocus
> the search box.

New description:

After recently upgrading to Django 4, we've had users report issues
related to the changes made in #34040. The users perform quite a lot of
these searches, and an extra click to focus the search box annoys them. I
wonder if it would be possible to restore the autofocus functionality when
in popup? In the popup context, I think it makes sense to autofocus the
search box since usability greatly improves.

--
--
Ticket URL: <https://code.djangoproject.com/ticket/35292#comment:2>

Django

unread,
Mar 12, 2024, 10:48:48 AM3/12/24
to django-...@googlegroups.com
#35292: Restore autofocus functionality to admin search box within popup interface
-------------------------------------+-------------------------------------
Reporter: Mattias L | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: invalid
Keywords: accessibility, | Triage Stage:
screen reader, autofocus | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* keywords: accessibility, screen reader, keyboard => accessibility,
screen reader, autofocus
* resolution: => invalid
* status: new => closed
* type: Uncategorized => Cleanup/optimization

Comment:

Hello Mattias, thank you for your report.

We should confirm with the accessibility team if this is an acceptable
proposal from the accessibility point of view. I do acknowledge that your
PR proposes to restore the `autofocus` only when there is a popup, but
it's unclear whether that will also be confusing screen readers.

My advice would be to reach out to them in
[https://forum.djangoproject.com/c/internals/accessibility/26 the
dedicated Accessibility category in the forum] and seek approval for the
proposal. Until then, I'll close the ticket as `invalid`, but if they do
approve this idea, please point us to the discussion and we'll re-open.
--
Ticket URL: <https://code.djangoproject.com/ticket/35292#comment:3>
Reply all
Reply to author
Forward
0 new messages