[Django] #35281: Use HTTP 413 status code for RequestDataTooBig

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig
-----------------------------------------+------------------------
Reporter: zvyn | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 5.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
Other HTTP servers (e.g. Apache, Nginx) report a body which is to large
with the status code 413 "Payload Too Large".

I propose to do the same in Django when handling a RequestDataTooBig
exception in
https://github.com/django/django/blob/f931cbec21cce3e2e68239c77614e6aa5026b882/django/core/handlers/exception.py#L63

This makes the behavior of a typical stack consisting of a reverse proxy
and a Django project predictable for this type of error.

I can work on a patch if this change is acceptable to you.
--
Ticket URL: <https://code.djangoproject.com/ticket/35281>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig

--------------------------------------+------------------------------------
Reporter: Milan Oberkirch | Owner: nobody
Type: Cleanup/optimization | Status: new

Component: HTTP handling | Version: 5.0

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted
* type: Uncategorized => Cleanup/optimization

Comment:

Following https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413 I
think the request makes sense.

I haven't found a previous report about this and the code that added some
handling for `RequestDataTooBig` may have missed to return a more specific
code. Tangential follow up of #27820.
--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:1>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig

-------------------------------------+-------------------------------------
Reporter: Milan Oberkirch | Owner: Milan
Type: | Oberkirch
Cleanup/optimization | Status: assigned

Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Milan Oberkirch):

* owner: nobody => Milan Oberkirch
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:2>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig
-------------------------------------+-------------------------------------
Reporter: Milan Oberkirch | Owner: Milan
Type: | Oberkirch
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by kokobhara):

Hello,

Is this issue still active?
I'm new to both Django and contributing to open-source, and would be more
than excited to work on a patch that fixes this.
--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:3>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig
-------------------------------------+-------------------------------------
Reporter: Milan Oberkirch | Owner: Milan
Type: | Oberkirch
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Milan Oberkirch):

Feel free to take over! Also note this comment:
https://github.com/django/django/pull/17960#pullrequestreview-1926197306
--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:4>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig

--------------------------------------+------------------------------------
Reporter: Milan Oberkirch | Owner: (none)
Type: Cleanup/optimization | Status: new

Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Milan Oberkirch):

* owner: Milan Oberkirch => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:5>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig

-------------------------------------+-------------------------------------
Reporter: Milan Oberkirch | Owner: kokobhara
Type: | Status: assigned
Cleanup/optimization |

Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by kokobhara):

* owner: (none) => kokobhara

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:6>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig
-------------------------------------+-------------------------------------
Reporter: Milan Oberkirch | Owner: kokobhara
Type: | Status: assigned
Cleanup/optimization |
Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Robin Swanson):

Hello, I noticed that there hasn't been a modification in 4 weeks. Is it
ok if I take over? I am a first time contributor to django and would love
the opportunity to take a crack at this.
--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:7>

[Django]

#35281: Use HTTP 413 status code for RequestDataTooBig

--------------------------------------+------------------------------------
Reporter: Milan Oberkirch | Owner: (none)
Type: Cleanup/optimization | Status: new

Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Simon Charette):

* easy: 1 => 0
* owner: kokobhara => (none)

* status: assigned => new

Comment:

Robin feel free to assign but take a minute to digest
[https://github.com/django/django/pull/17960#discussion_r1518576372 why
the efforts have stalled in the past weeks] first. I don't this this
constitutes an ''easy picking'' anymore.

Milan, I'll unassign given you closed your MR. Thank you for kicking off
the work.
--
Ticket URL: <https://code.djangoproject.com/ticket/35281#comment:8>